Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On 32-bit builds, JavaScript-controlled lengths can wrap an element-count multiplication before the allocator sees the request. For example,
Reflect.ownKeys(new Proxy({}, { ownKeys() { return { length: 0x20000000, 0: "x" }; } }))andArray.prototype.toReversed.call({ length: 0x20000000 })each reach an8 * lengthallocation that wraps to zero. The following element write can corrupt memory. The allocator-size guard in #556 cannot detect a size that has already wrapped.Change
ownKeystable as entries are validated, so a fake huge length does not allocate in advance and error cleanup only frees initialized atoms.This addresses the JavaScript paths described in #535 and complements the C allocator API fix in #556.
Validation
make -j8 teston macOS arm64make clean && make CONFIG_ASAN=y CONFIG_UBSAN=y -j8 teston macOS arm64