Repository navigation
Unit 1B: immutable publication authority and full authored release carrier - #3029
Draft
benhook1013 wants to merge 14 commits into
Draft
benhook1013 wants to merge 14 commits into
benhook1013 wants to merge 14 commits into
Conversation
…it1b-world-selector-release-carrier # Conflicts: # services/world-management-service/src/test/java/integration/net/firedevops/firemud/worldmanagement/tenant/WorldDraftGraphApplicationPostgresIntegrationTest.java
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Validation Summary❌ One or more validation checks failed
Coverage reports and failure logs are available in the workflow artifacts. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Boundary and dependency
Latest published correction
2961b4887has 93 unique files against the unchanged base. The owning V45 fixture adds one previously unchanged source path; the 90-file warning remains in force. Executed CI37536502118 on priordf35da130exposed one V45-to-current-schema fixture mismatch: the current table addsrevision, so comparing currentSELECT *maps to historical maps was invalid. The correction compares all fourteen original columns exactly and separately proves revision initialization, retained coordinator state, exact digest/retry, and no invented terminal/publication operations. Local affected Game Design fullCheck, formatting/static checks and boot JAR passed in 58s; PostgreSQL remains skipped locally. Corrected runner execution is required, and passing earlier scopes does not establish aggregate success or completed delivery.Published candidate
df35da130e46db892cf745d45bb9e69c0b83ea6d: 92 unique files, based on #30219f83e6dc24e23d99e8f9d20e6ea0dc87e505f5c7. The 90-file warning has been raised; the six additional files correct existing Account source-writer fixtures for this front's V79 dependency and preserve their original migration/history proof. They are not independently mergeable before that dependency. Normal commits preserve the earlier carrier and focused proof. #3035 owns the downstream authenticated World terminal delivery, lifecycle and Account settlement work. This draft is outside the configured queue pending Gameplay's actual receiving-base/insertion coordination; publication is not review admission or merge readiness.The four actual Gameplay handoffs remain OPEN: original Account-authorized World APPLIED; genuine immutable Game Design release; canonical World materialization → ACTIVE with Game Session association/placement; exact two-owner Account settlement. Broader Unit 1B/control UI stays parked.
Implemented unique boundary
RoomTemplateRefbefore allocation/replay, retaining a distinct runtime-room mapping.MATERIALIZED_UNVERIFIEDand stored PREPARING are not authenticated ACTIVE proof.publicationDigestRequest/v1remains a distinct owner-read binding.Latest executed CI and corrected checkpoint
CI37513419875 is attributable to prior head
c51596a42bd42d03cc29c2d58442bfb79d4fdfc6: synthetic merge7bb6d00cc0bd0f1809356880dbe9214e859af49bhas the exact ordered base/head parents and tree8861f7eb92a224f91a68f79773bb8f2b00edd0f8, matching the pinned local tree. Metadata-only workflows are not test execution evidence.Raw XML proves 12/12 Account publication, 8/8 Game Design release, 25/25 World graph, 2/2 canonical preparation, 4/4 legacy preparation, 12/12 authored snapshot, and 2/2 synchronized topology executed cleanly, with no skips. All four Game Design publication-operation cases executed: two passed and two failed, both at the fixture's missing asset candidate evidence, before the intended publication/rollback assertion. Dev Tool also rejected the misplaced XML-copy step between the immediate owner/fresh-source checks. The aggregate run completed failure at 2026-10-06 19:16:50 UTC; passing scoped suites are not an aggregate pass.
This corrected head stages real owner asset bytes, the exact frozen export snapshot and candidate evidence through existing services. Release fields derive from the committed candidate's independent exact readback, satisfying the PostgreSQL guard without bypassing it. The rollback and immutable-owner assertions are preserved. XML preservation now follows the immediate fresh-tenant/authored-source checks and capture, still before any later test selector. Corrected PostgreSQL execution remains required.
The 25 broad Account failures were separately traced to earlier commit
741c65d34within this PR: the current source-fence writer now consults V79 publication participation, but six fixture families cap their schemas below V79. Historical raw reports for unchanged Account source name the missing table; the exact c515 log repeats the same failing cases. Current-runtime fixtures now apply V79. Named V74 setup, V58→V59 and V66→V67 retained-data stages/assertions remain preserved, followed by the required current-schema upgrade. No runtime old-schema fallback or weakened authority guard is introduced. Corrected PostgreSQL execution of those assertions remains pending.Corrected-state CI37519508908 tested head
6a588f446f2290de19462480585adba04448597dthrough synthetic merge2732fc8306605cffcbcee2fc2c50efa3c230a5c8; ordered parents are the exact base/head and tree8fc1381aee2179ae84399e671013cf5a83afcf98equals the head tree. Metadata-only runs are excluded. Raw XML proves 4/4 Game Design publication, 8/8 release, 15/15 authored-world-state, 12/12 Account publication, 19/19 Account Draft authorization, 12/12 World graph, 2/2 canonical preparation and 2/2 synchronized topology executed cleanly without skips. The Account job passed; the prior 25 failures are not evidenced in this run. The aggregate still failed in Game Design and TCP.The remaining Game Design failure was the historical
v39MigrationPreservesRetainedPublicationEvidenceAndStoresLongDiagnosticsfixture: after migrating through V50, it attempted to mutate a terminal FAILED publication, correctly rejected by the immutable-terminal trigger. This candidate proves long diagnostic storage at V39 first, snapshots those rows, then proves latest-schema preservation and rejection of a terminal rewrite with exact no-mutation readback. It preserves revision, selector absence, original status/epoch and zero invented publication operations; no production guard is weakened. The local full Game Design/style/static/boot-JAR gate passes; all 161 integration cases still skip without Docker. Corrected PostgreSQL execution remains required. The earlier visibility/terminal/coordinator/selection suites have missing execution evidence after the failed Game Design job; passing publication cases do not fill those gaps.TCP's exact raw reports now establish 13 failures among 17 executions, returning
ERROR PLAY_IDENTITY_UNAVAILABLEafter LOGIN where PLAY success was expected. The underlying receiving cause is not inferred. This remains the OPEN Major Gameplay final PLAY/runtime-composition route30b0152eaf1b237b9835add5aab196843b76b1eae8b9353a0b93bc7dc852ca67and blocks #2898's genuine playable proof. Its receiving PR is intentionally unassigned until the actual consumer is published; #3041's STARTING/read support is not that closure. No publication-owned fix or discarded failure is claimed.Local validation and limits
Affected Game Design
check -PfullCheck, formatting, Checkstyle, SpotBugs, coverage, jOOQ generation, boot JAR, links and Markdown pass. Matching XML records 570 clean unit executions plus one separate unit skip, with cached matching outputs reused, and 161 integration cases skipped without Docker, including all four publication-operation cases. Actionlint, diff hygiene and all 230 architecture contract tests pass. PostgreSQL guard/race execution of the repaired fixture is still unavailable locally.The subsequent six-file Account correction passes
check -PfullCheck, formatting/static checks, jOOQ generation and boot JAR. Matching XML has 1,090 clean unit executions, with matching outputs reused, and all 500 integration cases skipped without Docker. Compilation and skipped discovery do not prove corrected migration, source-order or concurrency behavior.Earlier source-bound parent CI37474590468 proves 119 scoped PostgreSQL cases executed cleanly; it does not prove this child's migrations or delivery. Earlier front CI37505750548 omitted the publication-operation suite; that omission was corrected at c515, not counted as a pass. Preserved cumulative local checks and physical mTLS tests remain component proof, not deployed workload/fresh-image or live owner delivery.
Remaining authority and delivery gates
Authenticated freeze/terminal delivery, terminal-PUBLISHED-bound preparation, complete source/currentness and actual lifecycle/Game Session/Account composition remain open. A read adapter does not supply a prepare producer. #3035 retains default denial and the owner-local terminal/lifecycle transitions rather than dropping proof or manufacturing outcomes.
Unchanged published-content derivation does not renew creator permission. Activation still requires separate current exact-tenant tenantAdmin, entitlement/billing/quota/capacity and lifecycle authority; missing production producers remain tracked and denied. Explicitly isolated upstream policy fixtures and run-owned environments may exercise genuine SHARED owner transitions; they do not relabel playable scope or replace owner commits with snapshots.
Creator/admin canonical writers, membership RPC, credential release, ring mount and public activation stay denied. No provider review, corpus taper or merge readiness is claimed. FireController owns findings, routes and checkpoints.
FireMUD LOC impact
Compared
9f83e6dc24e2→2961b4887507(PR merge-base → head).PR scope: 93 changed files · 12,554 added textual lines / 523 deleted textual lines.
Rows are hierarchical and overlapping views; do not add them together.
LOC means cloc code lines; blank and comment-only lines are excluded.