[benhook1013]

Scope and stack

Account-owned issuer-source reads and original admission-COMMIT receipt prerequisites for Gameplay. Stacked on #3077 at 109a118f7754fe68e77aab0f09c27c751b733d98; 30 unique files. Broader Unit 1B remains parked. This is an unregistered source checkpoint, not review intake or merge readiness.

Implemented boundary

• Closed issuer-source protocol authenticates exact same-namespace Game Session and captures actual issuer generation, source version, checkpoint and complete retained event in one owned SERIALIZABLE transaction. Sequence zero requires genuine original 1/1 enrollment with no event; exact retries compare the whole source. The file-backed mTLS client verifies Account before releasing evidence. No recipient authority is inferred.
• The original finalization executor owns its concrete JDBC transaction and database-stamped finalization XID, verifies PostgreSQL 16 primary durability settings at physical COMMIT, then reads a conservatively rounded database clock on that same connection. Only successful original COMMIT followed by a bound strictly before unchanged expiry mints the opaque, non-serializable acknowledgement. Lost/late evidence and retained COMMITTED retries cannot remint it.
• V92 stores a separate immutable receipt bound to that acknowledgement and its configured Account DataSource. Its executor accepts only the opaque capability, observes the receipt's own qualified physical COMMIT, completes cleanup, then independently reads the exact result. A new retry transaction acknowledgement never proves an older receipt; retained recovery uses the separate conservative WAL-coverage read.
• Receipt storage derives the exact operation binding and receipt XID, preserves the original clock bound and expiry, and rejects updates, deletion and truncation. SQL checks binding/shape; it does not authenticate or independently derive the trusted-JVM original clock evidence.
• Published V91 and all V90 SQL remain unchanged. Gameplay's receiving migration is separately V93. Unrelated uncovered WAL can still deny historical recovery; no forced flush, marker, clock restamp, deadline extension or row-visibility fallback is added.

Focused proof

Seven new real-schema PostgreSQL definitions cover receipt-COMMIT/read ordering, source/binding substitution, lost original acknowledgement, same-transaction visibility rejection, lost receipt acknowledgement, historical exact recovery, and retained V91→V92 migration with immutable-receipt guards. CI now strictly requires each case to be present, unskipped and passing; missing/failed/skipped/duplicate evidence fails. Existing raw JUnit artifacts remain captured without filtered reruns.

Corrected R3 passes full Account checks, formatting, Checkstyle, SpotBugs, JaCoCo, integration-source compilation, boot packaging, links and Markdown in 3m10s. It freshly executes 1,268 Account unit cases and eight non-database integration cases with zero failures/errors; three unit cases and all 193 database cases skip. All 38 lease PostgreSQL definitions compile/discover but skip without Docker. The new receipt executor's 32 unit cases, repository/value's eight and original executor's 26 unit cases pass against labeled doubles, not PostgreSQL. R1's invalid negative fixture and R2's unnecessary static-analysis suppression were corrected without weakening any guard. Flyway sanity passes 12 migration sets and 170 versioned files. Actionlint and diff hygiene pass; synthetic strict-gate fixtures accept passing evidence and reject missing, failed, skipped and duplicate cases.

Remaining limits

Exact 223e59e046ddc53b7ab64a62253e3b7847b4d677 Account CI physically executes all 38 lease PostgreSQL cases, including all seven V92 cases, with zero failures/errors/skips in that suite. The earlier five V90 failures do not recur. The raw Account JUnit artifact reports 1,480 cases, seven skips and 1,473 executions with no failures/errors. Runner merge 95cc020a6963ea2e24ee9b97196f1df5faa13b15 has the exact base/source parents and tree 12bf14688df12ee629e457686f86595086c246da, identical to the published source. However, the Account job concludes cancelled despite every visible step, including Gradle and the strict V92 verifier, reporting success. Overseer confirmed the explicit 20-minute timeout annotation: Gradle succeeded at 05:37:49Z and cleanup reached the timeout at 05:38:43Z; the existing World allowance did not cover Account. Overseer owns the narrow timeout repair. This is executed database proof, not a successful Account CI check or aggregate green CI. No retry or additional observer was started merely to relabel that result.

Complete current Account restrictions/source authority, protected positive finalization composition, Game Session projection/installation/cleanup, real owner mTLS/database composition and fresh-image LOGIN → PLAY → LOOK remain unproved. No RPC, credential path, key-ring mount, protected owner or gameplay admission is enabled. Status is owned by Player Access and Session.

Bounded implementation helpers and the separate CI observer give no independent-review or provider-taper credit. No Hosted/CLI review, queue change, merge or activation is requested.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

• Configuration used: Repository YAML (base), Organization UI (inherited)
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 78d73b6c-0bf4-4498-b97f-53642f513d63

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Security Summary

✅ Security checks passed or were intentionally skipped

• ✅ Security gate: success
• ✅ Trivy filesystem scan: success
• ✅ Secret compliance validation: success

[codecov]

Codecov Report

❌ Patch coverage is 82.10526% with 153 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...ccountGameplayAdmissionOriginalCommitExecutor.java	80.00%	4 Missing and 20 partials ⚠️
.../authority/AccountIssuerAuthoritySourceClient.java	77.89%	10 Missing and 11 partials ⚠️
...authority/AccountIssuerSourceSnapshotEvidence.java	74.69%	8 Missing and 13 partials ⚠️
.../impl/AccountIssuerAuthoritySourceGrpcService.java	60.86%	17 Missing and 1 partial ⚠️
...uthority/AccountIssuerSourceSnapshotGrpcCodec.java	86.82%	7 Missing and 10 partials ⚠️
...playAdmissionOriginalAckReceiptCommitExecutor.java	87.50%	1 Missing and 11 partials ⚠️
...AccountGameplayAdmissionReceiptCommitExecutor.java	85.52%	1 Missing and 10 partials ⚠️
...pository/AccountIssuerSourceSnapshotReadOwner.java	86.41%	6 Missing and 5 partials ⚠️
...to/AccountGameplayAdmissionOriginalAckReceipt.java	78.04%	2 Missing and 7 partials ⚠️
...GameplayAdmissionOriginalAckReceiptRepository.java	88.75%	3 Missing and 6 partials ⚠️

📢 Thoughts on this report? Let us know!

[github-actions]

Static Analysis Summary

✅ Static analysis checks passed

• ✅ CodeQL gate: success
• ✅ License gate: success

CodeQL breakdown

• ⏭️ CodeQL analysis (java): skipped
• ⏭️ CodeQL analysis (javascript-typescript): skipped

[github-actions]

Validation Summary

❌ One or more validation checks failed

• ❌ Validation gate: failure
• ✅ Buf generation: success
• ✅ Dockerfile lint: success
• ✅ ShellCheck: success
• ✅ Python script validation: success
• ✅ Dev tool contract checks: success
• ⏭️ Dev Tools README contract: skipped
• ✅ YAML lint: success
• ✅ Metrics cardinality policy check: success
• ✅ Flyway migration sanity checks: success
• ✅ gRPC transport configuration sanity checks: success
• ✅ GitHub workflow lint: success
• ✅ Helm chart lint: success
• ✅ Helm render validation: success
• ✅ Helm transaction proof: success
• ✅ Validate Documentation: success
• ✅ Frontend checks: success
• ⚪ Service build/test matrix: cancelled

Coverage reports and failure logs are available in the workflow artifacts.