Repository navigation
Add standalone Account authorization and settlement for selected Game Logic intake - #3233
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Summary
Merge Risk: ⚪ Minimal · up to
|
Security Summary✅ Security checks passed or were intentionally skipped
|
Static Analysis Summary✅ Static analysis checks passed
CodeQL breakdown
|
Validation Summary✅ All validation checks passed
Coverage reports and failure logs are available in the workflow artifacts. |
…cument-game-logic-intake-account-20261015
…meplay-3233-published-receiving-20261015
…meplay-3233-published-receiving-20261015
…meplay-3233-published-receiving-20261015
…meplay-3233-published-receiving-20261015
…meplay-3233-published-receiving-20261015
…meplay-3233-published-receiving-20261015
…meplay-3233-client-close-receiving-20261016
|
@coderabbitai full review |
✅ Action performedFull review finished. |
|
Hosted: 0 Found / 0 Accepted / 0 Routed · 164c449 · 78 files · 8m 32s |
|
CLI: 3 Found / 3 Accepted / 0 Routed · 8e32be8 · 78 files · 3m 24s |
|
CLI: 2 Found / 2 Accepted / 0 Routed · 538a19b · 79 files · 3m 19s |
|
CLI: 1 Found / 0 Accepted / 0 Routed · 67ac9b9 · 80 files · 3m 20s |
|
CLI: 2 Found / 1 Accepted / 0 Routed · 67ac9b9 · 80 files · 3m 12s |
|
CLI: 1 Found / 1 Accepted / 0 Routed · e51feea · 81 files · 3m 11s |
|
CLI: 2 Found / 1 Accepted / 0 Routed · 2380095 · 81 files · 3m 29s |
Smoke Summary✅ Full-stack smoke completed with Smoke Gate: success
|
Adds standalone Account authorization, source reservation and recovery, HELD reads and terminal settlement for selected Game Logic intake. Account independently reads the exact Game Design source and Game Logic terminal, preserves immutable namespace/binding and replay evidence, and keeps remote owner reads outside SQL. Permanent owner refusals return sanitized precondition failures; database and transaction-creation outages remain retryable without leaking diagnostics. The seven intake clients reuse the existing file-backed mTLS policy and reloadable lifecycle, including shutdown outside the certificate-callback monitor. The Account receiver contract explicitly maps each receiver to its applicable 24 MiB message bound and states the protected credential metadata bound; service binding configures neither limit.
After User merged #3231, this PR is retargeted to
developand normally reconciled at975e240a1203onc4a877bb7d30. The entire tracked tree remains byte-identical toe3a2eb0c539b, preserving all 81 owned paths and existing closed review allocations. No implementation or validation claim is reset. The earlier retarget event supplied no merge SHA and its image guard refused a stale artifact; fresh candidate CI, images and required runtime proof are reported separately.Validation: the final receiver-limit wording correction passes documentation checks at
e3a2eb0c539b; runtime code is unchanged. All six focused loopback mTLS cases freshly pass at2380095e78bb, including the exact 16 KiB credential on authorize, recover and abort, with zero failures, errors or skips. Common Main/Test static analysis, formatting and documentation checks pass. The develop readiness repair is inherited without changing the owned patch. Eight Account settlement, authorization-read owner and authorization-read RPC cases freshly pass ate51feea11259, with zero failures, errors or skips. Account main/test static analysis and formatting pass in the separate full-check gate. Earlier qualification remains separately attributed: 11 World terminal RPC cases at67ac9b9aeadc, 30 intake transport cases ate2034dfadabf, and prior Account PostgreSQL owner proof. Published-head CI is separate.Owners and transports remain unregistered. Controlled upstream sources and loopback PKI do not establish genuine authoring, deployed authority, activation or delivery. Game Logic retention and its receipt composition belong to #3236; all genuine Gameplay handoffs remain open.
FireMUD LOC impact
Compared
c4a877bb7d30→975e240a1203(PR merge-base → head).PR scope: 81 changed files · 12,898 added textual lines / 3 deleted textual lines.
Rows are hierarchical and overlapping views; do not add them together.
LOC means cloc code lines; blank and comment-only lines are excluded.