Repository navigation
Improve startup fault capture, attribution and experiment reports - #34
Draft
benjaminRomano wants to merge 3 commits into
Draft
benjaminRomano wants to merge 3 commits into
benjaminRomano wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Startup captures could exhaust fixed native arrays, lose Simpleperf samples, or overwrite initial Perfetto data. Reports also conflated independently recorded managed stacks with fault-page evidence and lacked a reproducible way to re-symbolicate and compare repeated runs.
This change:
-mand--user-buffer-sizeand links the upstream stack/deobfuscation reports.--report-onlyrendering with input/renderer/tool hashes, architecture/build-ID matched native symbols, exact-build mapping assertions and explicit merged/ambiguous Java origins.<clinit>roots, and staged OAT failure diagnostics.Validation:
./gradlew build shadowJar generateDocs: passed; 267 JVM tests (10 environment-gated skips), 30 Node tests.-Wall -Wextra -Werror; Simpleperf patch applies cleanly to Google's event-selection source.Draft limitation: the modified address-bearing Simpleperf recorder has binary parser regression coverage but has not been AOSP-built or validated on a device. Exact managed fault-page attribution remains experimental until that check; the stock independent-stack path was validated live. The supplied mapping/profile build identity is an explicit assertion tied to the captured APK hash, not independent proof of the build pipeline's consumed inputs.
Usage and evidence semantics: startup fault attribution guide.
Follow-up end-to-end verification (2026-09-11,
5b01fd2):