Skip to content

Update palantir-java-format, Checker, langchain4j, the agent's deps and clang-format - #477

Merged
bernardladenthin merged 1 commit into
mainfrom
claude/hopeful-pascal-9jlbqb
Oct 6, 2026
Merged

bernardladenthin merged 1 commit into
mainfrom
claude/hopeful-pascal-9jlbqb

Conversation

@bernardladenthin

Copy link
Copy Markdown
Owner

Summary

  • palantir-java-format 2.100.0 → 2.102.0 in the core and the agent. spotless:apply changes no source file.
  • Checker Framework 4.2.3 → 4.3.0. The processor and checker-qual move together, because they must share a major version.
  • langchain4j-core 1.20.2 → 1.21.0 (llama-langchain4j).
  • Agent:
    • Atmosphere 4.0.71 → 4.0.72
    • Jetty 12.1.13 → 12.1.14
    • JLine 4.4.6 → 4.4.7. The agent's eight carried JLine fixes change only Status, Display and LineReaderImpl, and none of those three files differs between 4.4.6 and 4.4.7. 4.4.7 itself only fixes AttributedStringBuilder tab positions, Curses.tputs, Telnet NEW-ENVIRON limits and a ReDoS in the history commands.
  • clang-format 23.1.1 → 23.1.3. The whole checked C++ tree is already clean under it, so no source changes.
  • CHANGELOG, CLAUDE.md and the agent's CLAUDE.md are updated.

The same palantir/Checker versions go to BitcoinAddressFinder, srcmorph and streambuffer in parallel PRs (streambuffer already has Checker 4.3.0 from Dependabot).

Test plan

  • Reactor install, including SpotBugs, is green
  • Core tests: 1835 run, 0 failures (277 model-gated tests skipped locally)
  • llama-langchain4j verify: 49 tests, 0 failures
  • Agent verify -Dllama.natives=none: 277 tests, 0 failures
  • check-natives, check-shared-files and check-run-scripts are clean
  • CI is green on this branch
  • Docs / CHANGELOG updated

Related issues / PRs

Part of the 2026-10-06 cross-repo dependency sweep. OpenJML 21.0.28 is left out on purpose; it is being evaluated separately.

Checklist

  • No security-sensitive changes

🤖 Generated with Claude Code

https://claude.ai/code/session_01AytmJF9faEiQEVt6eetQS2


Generated by Claude Code

…nd clang-format

- palantir-java-format 2.100.0 -> 2.102.0 (core + agent): no reformatting.
- Checker Framework 4.2.3 -> 4.3.0 (processor and checker-qual together,
  as they must share a major version).
- langchain4j-core 1.20.2 -> 1.21.0 (llama-langchain4j).
- Agent: Atmosphere 4.0.71 -> 4.0.72, Jetty 12.1.13 -> 12.1.14,
  JLine 4.4.6 -> 4.4.7. None of the three files the carried JLine fixes
  change (Status, Display, LineReaderImpl) differs between 4.4.6 and
  4.4.7; 4.4.7 only fixes AttributedStringBuilder tabs, Curses.tputs,
  telnet and a history ReDoS.
- clang-format 23.1.1 -> 23.1.3: zero churn over the checked tree.

Checked: reactor install (SpotBugs included) green; core 1835 tests,
llama-langchain4j 49, agent 277 (-Dllama.natives=none), 0 failures;
check-natives, check-shared-files, check-run-scripts clean.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AytmJF9faEiQEVt6eetQS2
@claude

claude Bot commented Oct 6, 2026

Copy link
Copy Markdown

Review Summary ✅

This is a well-executed dependency update PR with excellent documentation and testing. The changes are clean, consistent, and properly documented.

Verification Notes

Strengths:

  • ✅ All dependency version updates are consistent across affected pom files (llama/pom.xml, llama-langchain4j/pom.xml, llama-atmosphere-agent/pom.xml)
  • ✅ Checker Framework version management: Correctly updated 4.2.3 → 4.3.0 while maintaining the "same major version" constraint that both the processor and checker-qual must share (explained clearly in CLAUDE.md)
  • ✅ JLine carried fixes: PR correctly verifies that none of the three files the carried JLine fixes touch (Status, Display, LineReaderImpl) changed between 4.4.6 and 4.4.7
  • ✅ Documentation: All version references updated in:
    • CLAUDE.md (clang-format, Checker Framework documentation)
    • llama-atmosphere-agent/CLAUDE.md (Atmosphere version)
    • CHANGELOG.md (new entry for langchain4j, Atmosphere, Jetty, JLine versions)
  • ✅ Testing: Comprehensive local test results reported:
    • Reactor install + SpotBugs: green
    • Core: 1835 tests, 0 failures
    • llama-langchain4j: 49 tests, 0 failures
    • Agent: 277 tests, 0 failures
    • Build checks (check-natives, check-shared-files, check-run-scripts): clean
  • ✅ No code changes: Only dependency versions and documentation updates
  • ✅ No security concerns: All updates are patch or minor version bumps for build tools and dependencies

Minor Note:

  • CI has not completed yet (as noted in the PR), but pre-CI validation is comprehensive

Recommendations

  • Ready to merge once CI passes
  • Cross-repo PRs (BitcoinAddressFinder, srcmorph, streambuffer) mentioned as parallel — verify those merge to maintain cross-repo consistency

@claude

claude Bot commented Oct 6, 2026

Copy link
Copy Markdown

Detailed Change Verification

Version Consistency Check ✅

All version updates are properly coordinated across modules:

Component Old → New Files Updated
palantir-java-format 2.100.0 → 2.102.0 llama/pom.xml, llama-atmosphere-agent/pom.xml
Checker Framework 4.2.3 → 4.3.0 llama/pom.xml (processor + qualifier-qual)
langchain4j-core 1.20.2 → 1.21.0 llama-langchain4j/pom.xml
Atmosphere 4.0.71 → 4.0.72 llama-atmosphere-agent/pom.xml, CLAUDE.md
Jetty 12.1.13 → 12.1.14 llama-atmosphere-agent/pom.xml
JLine 4.4.6 → 4.4.7 llama-atmosphere-agent/pom.xml
clang-format 23.1.1 → 23.1.3 .github/workflows/clang-format.yml, CLAUDE.md

Bytecode Compatibility ✅

  • Checker Framework 4.3.0: Still provided scope (doesn't ship to consumers), maintained compatibility constraint that processor + checker-qual must share major version
  • No impact on Java 8 bytecode floor: All changes are build-time or test-time dependencies
  • langchain4j-core 1.21.0: Correctly placed in llama-langchain4j module (Java 17 floor) — not affecting core (Java 8)

Documentation Consistency ✅

All documentation accurately reflects version changes. No stale references found.


Overall Assessment: This PR exhibits excellent quality control with thorough pre-CI validation. All cross-module dependencies are synchronized, documentation is complete, and the testing is comprehensive.

@sonarqubecloud

sonarqubecloud Bot commented Oct 6, 2026

Copy link
Copy Markdown

@bernardladenthin
bernardladenthin merged commit 4c3e70d into main Oct 6, 2026
13 of 17 checks passed
@bernardladenthin
bernardladenthin deleted the claude/hopeful-pascal-9jlbqb branch October 6, 2026 22:21

This branch had an error being deployed

1 failed deployment
maven-central — 491513be Deployed Oct 6, 2026 by bernardladenthin via Verify GPG signing key (no secrets printed) #1092
startgate — 491513be Deployed Oct 6, 2026 by bernardladenthin via Start gate (abort window) #1092
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants