Patches for setting up the UTF8-named directory for BOOST - #421
Closed
tjcw wants to merge 2 commits into
Closed
Conversation
This was referenced Nov 5, 2024
grafikrobot
requested changes
Nov 11, 2024
grafikrobot
left a comment
grafikrobot
left a comment
Member
There was a problem hiding this comment.
These new toolsets are almost identical to the existing vacpp+xlcpp, and to each other. It would make more sense to create a single toolset that can deal with the minor variations in each instead of two more.
Comment on lines
+9
to
+10
| mkdir libs\wave\test\testwave\testfiles\utf8-test-ßµ™∃ | ||
| copy libs\wave\test\testwave\testfiles\utf8-test\file.hpp libs\wave\test\testwave\testfiles\utf8-test-ßµ™∃\file.hpp |
Member
There was a problem hiding this comment.
These paths do not exists in the B2 sources. And hence fail when this script is run. These changes, if wanted, belong in the Boost bootstrap.
| cp "./src/engine/b2.exe" . 2>/dev/null | ||
|
|
||
| # Fix up the UTF8 test (AIX does not support utf8 file/dir names) | ||
| cp -r libs/wave/test/testwave/testfiles/utf8-test libs/wave/test/testwave/testfiles/utf8-test-ßµ™∃ |
Member
There was a problem hiding this comment.
These paths do not exists in the B2 sources. And hence fail when this script is run. These changes, if wanted, belong in the Boost bootstrap.
Member
|
I've converted this to a draft as it needs discussion and more work. |
grafikrobot
marked this pull request as draft
November 11, 2024 00:56
14 tasks
Author
|
After re-checking, it looks like AIX does not need this patch. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
I have troubles unpacking BOOST on AIX, because AIX does not support unicode file/directory names and there is a file in BOOST tests with a unicode name. This PR combines with a PR in the BOOST 'wave' repository so that the directory is unpacked with a regular name and renamed to its unicode name at bootstrap time. boostorg/wave#233 is the PR to look at.
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyUsability improvement for BOOST on AIX
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.I checked that the 'wave' tests still pass on my Linux workstation after making the change.
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...