Skip to content

feat: Access gzip header through context - #79

Merged
effigies merged 3 commits into
bids-standard:mainfrom
effigies:gzip
Jun 29, 2026
Merged

feat: Access gzip header through context#79
effigies merged 3 commits into
bids-standard:mainfrom
effigies:gzip

Conversation

@effigies

Copy link
Copy Markdown
Contributor

Closes #51.

@effigies
effigies requested a review from ubdbra001 June 28, 2026 18:25
@codecov

codecov Bot commented Jun 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.59574% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.56%. Comparing base (e85ad33) to head (45b19e3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
- Coverage   90.89%   90.56%   -0.34%     
==========================================
  Files          13       13              
  Lines         846      890      +44     
  Branches      124      130       +6     
==========================================
+ Hits          769      806      +37     
- Misses         47       50       +3     
- Partials       30       34       +4     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ubdbra001 ubdbra001 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all makes sense to me.
mypy is complaining about 2 lines, but I think they are false positives. Might still be worth ignoring those rules for those lines so the errors don't crop up again in future.

Comment thread tests/test_context.py Outdated
Comment thread src/bids_validator/context.py Outdated
@effigies
effigies merged commit 9f0cf65 into bids-standard:main Jun 29, 2026
22 of 23 checks passed
@effigies
effigies deleted the gzip branch June 29, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Populate gzip context

2 participants