Skip to content

Add pyright checking, use pre-commit for code reformatting#32

Merged
reece merged 7 commits into
mainfrom
4-add-pyright-support-to-cicd
Sep 26, 2023
Merged

Add pyright checking, use pre-commit for code reformatting#32
reece merged 7 commits into
mainfrom
4-add-pyright-support-to-cicd

Conversation

@dylan-myome

Copy link
Copy Markdown
Contributor

No description provided.

@dylan-myome
dylan-myome requested a review from reece as a code owner September 18, 2023 23:28
@dylan-myome dylan-myome linked an issue Sep 18, 2023 that may be closed by this pull request
@codecov

codecov Bot commented Sep 18, 2023

Copy link
Copy Markdown

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d555abe) 100.00% compared to head (978205b) 100.00%.

❗ Current head 978205b differs from pull request most recent head 143d277. Consider uploading reports for the commit 143d277 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #32   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           18        18           
=========================================
  Hits            18        18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread src/biocommons/example/tests/conftest.py
ecalifornica
ecalifornica previously approved these changes Sep 19, 2023

@ecalifornica ecalifornica left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment thread pyproject.toml Outdated
ecalifornica
ecalifornica previously approved these changes Sep 19, 2023

@ecalifornica ecalifornica left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@reece
reece merged commit d22ce00 into main Sep 26, 2023
@reece
reece deleted the 4-add-pyright-support-to-cicd branch September 26, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add pyright support to ci/cd

3 participants