Skip to content

build: update supported python versions to include 3.12#42

Merged
reece merged 1 commit into
mainfrom
38-update-supported-python-versions
Jul 6, 2024
Merged

build: update supported python versions to include 3.12#42
reece merged 1 commit into
mainfrom
38-update-supported-python-versions

Conversation

@korikuzma

Copy link
Copy Markdown
Contributor

close #38

  • support the 3 most recent python releases: 3.10, 3.11, 3.12

* support the 3 most recent python releases: 3.10, 3.11, 3.12
@korikuzma korikuzma self-assigned this Apr 2, 2024
@korikuzma
korikuzma requested a review from a team as a code owner April 2, 2024 00:35
Comment thread tox.ini

[gh]
python =
3.9 = py39, type

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what the type was for. Do I need to add this back?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO delete it here and discuss in #43

@codecov

codecov Bot commented Apr 2, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9aa8d98) to head (b695995).
Report is 31 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #42   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           18        18           
=========================================
  Hits            18        18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@korikuzma

Copy link
Copy Markdown
Contributor Author

@reece how can we update all repos with this change?

@reece

reece commented Apr 22, 2024

Copy link
Copy Markdown
Member

At maintainers meeting, agreed to upgrade repos to importlib (and remove pkg_resources) before supporting 3.12.

@reece reece changed the title build: update supported python versions build: update supported python versions to include 3.12 Apr 22, 2024
@reece
reece marked this pull request as draft April 22, 2024 16:28
@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@jsstevenson

jsstevenson commented Jun 4, 2024

Copy link
Copy Markdown
Contributor

I've created test PRs for most of the major repos (hesitant to do too much in UTA since I know it's undergoing a significant refactor). SeqRepo requires a temporary pin of setuptools until yoyo-migrations releases a new version (TBD?) but everything looks smooth otherwise. It'd be nice to start moving on this soon.

@korikuzma
korikuzma marked this pull request as ready for review June 24, 2024 16:19
@korikuzma
korikuzma requested a review from a team June 24, 2024 16:21

@jsstevenson jsstevenson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@korikuzma
korikuzma requested a review from reece July 1, 2024 11:28
@reece
reece merged commit 4b53543 into main Jul 6, 2024
@reece
reece deleted the 38-update-supported-python-versions branch July 6, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

keep alive exempt issue from staleness checks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update supported python versions

3 participants