Translate unit names & fix external signer error by luke-jr · Pull Request #599 · bitcoin-core/gui

luke-jr · 2022-05-15T22:32:32Z

I think I got everything under src/qt missing translatability.

Exceptions:

Punctuation-only (this is a can of worms)
Date/time (long-standing ignoring of locale, not sure anyone minds)
Obscure errors
Technical terms in transactiondesc

Notably, I did include units. Not only for the benefit of non-Latin languages, but also we have "bits" and "sats" nowadays that likely make sense to translate even in Latin-based languages.

(Much of this was merged in #724 already)

Jilasoon

.

hebasto · 2022-06-01T22:26:36Z

Concept ACK.

DrahtBot · 2022-06-12T21:44:59Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
Concept ACK	hebasto, furszy

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#bitcoin/bitcoin/29015 (kernel: Streamline util library by ryanofsky)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

furszy

Concept ACK and initial code review ACK 5e23dab

As it has a good number of changes, will give it another look in the coming days.

luke-jr · 2022-09-03T03:43:37Z

Rebased (no changes, just had to re-generate the make translate outputs)

hebasto · 2023-02-27T13:32:55Z

Concept ACK.

Concept ACK and initial code review ACK 5e23dab

@luke-jr

Mind rebasing this PR before soft translation string freeze?

hebasto · 2023-03-31T11:32:29Z

+    //: Tooltip description of "BTC" unit in dropbox selector
+    case Unit::BTC: return tr("Bitcoins", "unit description");
+    //: Tooltip description of "mBTC" unit in dropbox selector
+    case Unit::mBTC: return tr("Milli-Bitcoins (1 / 1" THIN_SP_UTF8 "000)", "unit description");


2e55d10

It seems not passing to the translation file properly.

e414edd qt: Update translation source file (Hennadii Stepanov) b780095 qt: Adjust plural forms for translations (Hennadii Stepanov) 6ae8a24 GUI: Send: Make feerates translatable (Luke Dashjr) bd42f5e Bugfix: GUI: Send/PSBT: Correct virtual size unit and make translatable (Luke Dashjr) 1b0407f Bugfix: GUI: transactiondesc: Translate outlier "own address" and "watch-only" (Luke Dashjr) 170f312 GUI: Use translated external signer errors for messagebox text (Luke Dashjr) 9698959 GUI: Make messages for copying unsigned PSBTs translatable (Luke Dashjr) 08b8b28 Bugfix: GUI: Debug info: Use correct "kB" case for small mempool sizes, and make translation-friendly (Luke Dashjr) dacc322 GUI: PSBTOperationsDialog: Support translating window title (Luke Dashjr) 5a4fe55 GUI: Intro: Support translating caption of data directory chooser (Luke Dashjr) 3868ba3 GUI: Support translating peer network names (Luke Dashjr) f1f9811 GUI: Support translating address type dropdown entries (Luke Dashjr) Pull request description: This PR updates the `src/qt/locale/bitcoin_en.xlf` translation source file according to [Release schedule for 25.0](bitcoin/bitcoin#26549). Some translation-related fixes have been picked from #599 and #716. Note for reviewers: it is expected to get a zero diff after running `make -C src translate` locally. ACKs for top commit: jarolrod: ACK e414edd Tree-SHA512: 5b0c70db1e2f5871067e84f43ebea4ee4f0027fc5f2be49bbcb1d04e162ae76607b2b038e9d0622bcb5b3658d0ede8c10c4421ddaa3343f0e0be54315ca7a4f5

hebasto · 2023-04-01T21:09:39Z

Most of commits from this PR were merged as a part of #724.

luke-jr · 2023-06-29T22:02:16Z

Rebased. Only units and the external signer bugfix remain. I didn't regenerate translations this time.

…nal signer fails inexplicably

DrahtBot · 2024-06-12T22:24:40Z

🐙 This pull request conflicts with the target branch and needs rebase.

DrahtBot · 2024-09-09T01:14:23Z

⌛ There hasn't been much activity lately and the patch still needs rebase. What is the status here?

Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
Is it no longer relevant? ➡️ Please close.
Did the author lose interest or time to work on this? ➡️ Please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future.

DrahtBot · 2024-12-07T01:30:59Z

⌛ There hasn't been much activity lately and the patch still needs rebase. What is the status here?

Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
Is it no longer relevant? ➡️ Please close.
Did the author lose interest or time to work on this? ➡️ Please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future.

…string freeze 4a5155e qt: Update translation source file (Hennadii Stepanov) a917c4b qt: Adjust plural forms for translations (Hennadii Stepanov) 9cb6f85 GUI: Send: Make feerates translatable (Luke Dashjr) e3fa012 Bugfix: GUI: Send/PSBT: Correct virtual size unit and make translatable (Luke Dashjr) 83470ab Bugfix: GUI: transactiondesc: Translate outlier "own address" and "watch-only" (Luke Dashjr) 2c0ba6b GUI: Use translated external signer errors for messagebox text (Luke Dashjr) ff1311a GUI: Make messages for copying unsigned PSBTs translatable (Luke Dashjr) 209b650 Bugfix: GUI: Debug info: Use correct "kB" case for small mempool sizes, and make translation-friendly (Luke Dashjr) 5a32944 GUI: PSBTOperationsDialog: Support translating window title (Luke Dashjr) 83f11b1 GUI: Intro: Support translating caption of data directory chooser (Luke Dashjr) 74d16c9 GUI: Support translating peer network names (Luke Dashjr) 0254ee5 GUI: Support translating address type dropdown entries (Luke Dashjr) Pull request description: This PR updates the `src/qt/locale/bitcoin_en.xlf` translation source file according to [Release schedule for 25.0](bitcoin/bitcoin#26549). Some translation-related fixes have been picked from bitcoin-core/gui#599 and bitcoin-core/gui#716. Note for reviewers: it is expected to get a zero diff after running `make -C src translate` locally. ACKs for top commit: jarolrod: ACK 4a5155e Tree-SHA512: 5b0c70db1e2f5871067e84f43ebea4ee4f0027fc5f2be49bbcb1d04e162ae76607b2b038e9d0622bcb5b3658d0ede8c10c4421ddaa3343f0e0be54315ca7a4f5

…string freeze 7ec6853 qt: Update translation source file (Hennadii Stepanov) 24d456b qt: Adjust plural forms for translations (Hennadii Stepanov) e525396 GUI: Send: Make feerates translatable (Luke Dashjr) e440c77 Bugfix: GUI: Send/PSBT: Correct virtual size unit and make translatable (Luke Dashjr) c9b5581 Bugfix: GUI: transactiondesc: Translate outlier "own address" and "watch-only" (Luke Dashjr) 385db7f GUI: Use translated external signer errors for messagebox text (Luke Dashjr) 7ece091 GUI: Make messages for copying unsigned PSBTs translatable (Luke Dashjr) 94e020d Bugfix: GUI: Debug info: Use correct "kB" case for small mempool sizes, and make translation-friendly (Luke Dashjr) 6f5ec50 GUI: PSBTOperationsDialog: Support translating window title (Luke Dashjr) 109364d GUI: Intro: Support translating caption of data directory chooser (Luke Dashjr) 572bc1c GUI: Support translating peer network names (Luke Dashjr) 474daec GUI: Support translating address type dropdown entries (Luke Dashjr) Pull request description: This PR updates the `src/qt/locale/bitcoin_en.xlf` translation source file according to [Release schedule for 25.0](bitcoin/bitcoin#26549). Some translation-related fixes have been picked from bitcoin-core/gui#599 and bitcoin-core/gui#716. Note for reviewers: it is expected to get a zero diff after running `make -C src translate` locally. ACKs for top commit: jarolrod: ACK 7ec6853 Tree-SHA512: 5b0c70db1e2f5871067e84f43ebea4ee4f0027fc5f2be49bbcb1d04e162ae76607b2b038e9d0622bcb5b3658d0ede8c10c4421ddaa3343f0e0be54315ca7a4f5

…string freeze e414edd8fc88b55a91f446dcc4d55cc4cd6d32e7 qt: Update translation source file (Hennadii Stepanov) b7800950913c47bc1a939bd7f99c6b0629aea530 qt: Adjust plural forms for translations (Hennadii Stepanov) 6ae8a24009cb006476b3be612a34e4deda30433a GUI: Send: Make feerates translatable (Luke Dashjr) bd42f5e1cdb0cbd829c8fe1700d036b681f3930d Bugfix: GUI: Send/PSBT: Correct virtual size unit and make translatable (Luke Dashjr) 1b0407f5f1f5902f67b58c7ada9c4b0c45457244 Bugfix: GUI: transactiondesc: Translate outlier "own address" and "watch-only" (Luke Dashjr) 170f3126f220f9ffe3db471e0024a23dede3f90b GUI: Use translated external signer errors for messagebox text (Luke Dashjr) 96989599d6c7264022c188babdcd9cacac9ab69f GUI: Make messages for copying unsigned PSBTs translatable (Luke Dashjr) 08b8b287d3762dd6d4be09fad0b71c4cacfe6658 Bugfix: GUI: Debug info: Use correct "kB" case for small mempool sizes, and make translation-friendly (Luke Dashjr) dacc322be10c6709338d2f0d7f5c4366609ad1a0 GUI: PSBTOperationsDialog: Support translating window title (Luke Dashjr) 5a4fe5527045ad3d7f1c834c3c6ea1d531c87879 GUI: Intro: Support translating caption of data directory chooser (Luke Dashjr) 3868ba3a27d594dd2968548fff3db457cbeb0080 GUI: Support translating peer network names (Luke Dashjr) f1f981119884389f1f355bc11847a73812a2836e GUI: Support translating address type dropdown entries (Luke Dashjr) Pull request description: This PR updates the `src/qt/locale/bitcoin_en.xlf` translation source file according to [Release schedule for 25.0](bitcoin/bitcoin#26549). Some translation-related fixes have been picked from bitcoin-core/gui#599 and bitcoin-core/gui#716. Note for reviewers: it is expected to get a zero diff after running `make -C src translate` locally. ACKs for top commit: jarolrod: ACK e414edd8fc88b55a91f446dcc4d55cc4cd6d32e7 Tree-SHA512: 5b0c70db1e2f5871067e84f43ebea4ee4f0027fc5f2be49bbcb1d04e162ae76607b2b038e9d0622bcb5b3658d0ede8c10c4421ddaa3343f0e0be54315ca7a4f5

luke-jr mentioned this pull request May 15, 2022

Translatability fixups bitcoin/bitcoin#25140

Closed

Jilasoon suggested changes May 15, 2022

View reviewed changes

hebasto added the Translations label May 20, 2022

This comment was marked as off-topic.

Sign in to view

furszy reviewed Jul 1, 2022

View reviewed changes

DrahtBot added the Needs rebase label Aug 8, 2022

luke-jr force-pushed the ts_20220515 branch from 5e23dab to 7ec30cf Compare September 3, 2022 03:43

DrahtBot removed the Needs rebase label Sep 3, 2022

DrahtBot added the Needs rebase label Sep 14, 2022

hebasto mentioned this pull request Mar 31, 2023

Update translation source file for v25.0 string freeze #724

Merged

hebasto reviewed Mar 31, 2023

View reviewed changes

luke-jr force-pushed the ts_20220515 branch from 7ec30cf to e119c5a Compare June 29, 2023 22:00

luke-jr changed the title ~~Translatability fixups~~ Translate unit names & fix external signer error Jun 29, 2023

luke-jr added 2 commits June 29, 2023 22:06

Bugfix: GUI: Display error messagebox (rather than stderr) when exter…

f4fe307

…nal signer fails inexplicably

GUI: Support translating Bitcoin units

d941132

luke-jr force-pushed the ts_20220515 branch from e119c5a to d941132 Compare June 29, 2023 22:06

DrahtBot removed the Needs rebase label Jun 30, 2023

DrahtBot added CI failed and removed CI failed labels Aug 18, 2023

DrahtBot added CI failed and removed CI failed labels Aug 31, 2023

DrahtBot added the CI failed label Oct 25, 2023

DrahtBot mentioned this pull request Dec 13, 2023

kernel: Streamline util library bitcoin/bitcoin#29015

Merged

DrahtBot added the Needs rebase label Jun 12, 2024

luke-jr closed this Feb 8, 2025

Navigation Menu

Translate unit names & fix external signer error - #599

Translate unit names & fix external signer error#599
luke-jr wants to merge 2 commits into
bitcoin-core:masterfrom
luke-jr:ts_20220515

luke-jr commented May 15, 2022 •

edited

Loading

Uh oh!

Jilasoon left a comment •

edited by fanquake

Loading

Uh oh!

hebasto commented Jun 1, 2022

Uh oh!

This comment was marked as off-topic.

DrahtBot commented Jun 12, 2022 •

edited

Loading

Uh oh!

furszy left a comment

Uh oh!

luke-jr commented Sep 3, 2022

Uh oh!

hebasto commented Feb 27, 2023

Uh oh!

hebasto Mar 31, 2023

Uh oh!

hebasto commented Apr 1, 2023

Uh oh!

luke-jr commented Jun 29, 2023

Uh oh!

DrahtBot commented Jun 12, 2024

Uh oh!

DrahtBot commented Sep 9, 2024

Uh oh!

DrahtBot commented Dec 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

luke-jr commented May 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jilasoon left a comment • edited by fanquake Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hebasto commented Jun 1, 2022

Uh oh!

This comment was marked as off-topic.

DrahtBot commented Jun 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews

Conflicts

Uh oh!

furszy left a comment

Choose a reason for hiding this comment

Uh oh!

luke-jr commented Sep 3, 2022

Uh oh!

hebasto commented Feb 27, 2023

Uh oh!

hebasto Mar 31, 2023

Choose a reason for hiding this comment

Uh oh!

hebasto commented Apr 1, 2023

Uh oh!

luke-jr commented Jun 29, 2023

Uh oh!

DrahtBot commented Jun 12, 2024

Uh oh!

DrahtBot commented Sep 9, 2024

Uh oh!

DrahtBot commented Dec 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

luke-jr commented May 15, 2022 •

edited

Loading

Jilasoon left a comment •

edited by fanquake

Loading

DrahtBot commented Jun 12, 2022 •

edited

Loading