refactor(config): improve startup errors and remove inactive assertions - #45
Draft
bladehan1 wants to merge 1 commit into
Draft
refactor(config): improve startup errors and remove inactive assertions#45bladehan1 wants to merge 1 commit into
bladehan1 wants to merge 1 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Use TronError with PARAMETER_INIT for invalid startup configuration, remove assertions that are inactive at runtime, and cover the new error paths with unit tests.
bladehan1
force-pushed
the
feature/opt_config_error
branch
from
August 6, 2026 09:51
79e165c to
c95607d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
IllegalArgumentExceptionfailures withTronError(PARAMETER_INIT).Why are these changes required?
The selected failures are parameter initialization errors. Classifying them with
PARAMETER_INITmakes startup failures consistent while preserving their messages and exit behavior. Removing inactive assertions avoids implying that production runtime validation is present. The added tests prevent these error paths from regressing and ensure they are included in the CI coverage data.This PR has been tested by:
./gradlew :common:test --tests org.tron.core.config.args.CommitteeConfigTest./gradlew :framework:test --tests org.tron.core.config.args.ArgsTest./gradlew :common:jacocoTestReport :framework:jacocoTestReportCommitteeConfig.java:166andArgs.java:1048,1092../gradlew :framework:checkstyleTestgit diff --checkFollow up
Other startup failures should be evaluated separately according to their semantics.
Extra details
developand contains one consolidated commit.Summary by cubic
Standardizes startup configuration errors using
TronError(PARAMETER_INIT)and removes inactiveassertstatements. Adds tests to cover these error paths; valid config behavior is unchanged.IllegalArgumentExceptionwithTronError(PARAMETER_INIT)inCommitteeConfigand DNS publish config (Args.loadDnsPublishParameters,logEmptyError).assertstatements fromRepositoryImpl,ResourceProcessor,EnergyProcessor,MerklePath, and multiple methods inTrieImpl.CommitteeConfigTestandArgsTestto assertPARAMETER_INITcodes and messages for invalidcommittee.allowOldRewardOptand DNS publish inputs.Written for commit c95607d. Summary will update on new commits.