fix(desktop): restore macOS navigation chrome alignment#1797
Conversation
Signed-off-by: npub13fn4ahfnvaa2qwylvegdgeajqs0mph6v4qsw4jcqnw4mjh3hzh2quuucm5 <8a675edd33677aa0389f6650d467b2041fb0df4ca820eacb009babb95e3715d4@sprout-oss.stage.blox.sqprod.co>
wesbillman
left a comment
There was a problem hiding this comment.
Verified this is an exact restoration: git diff 89e2e2e4a~1 ed22f7ef (pre-#1717 main vs this head) is empty for both AppTopChrome.tsx and the trafficLightPosition block — the PR puts back precisely what #1717 accidentally dropped while keeping its intended launch-motion changes (visible: false + the native reveal plugin) untouched. The spec is in the smoke project's testMatch and all four smoke shards ran it green, so the new placement guards are exercised in CI, not just locally.
Non-blocking nit: the spec now hardcodes {x:16, y:24} a second time and asserts an exact 23px nav center — brittle in principle, but consistent with this file's existing exact-px style (40px bar, 28px buttons), so fine. If it ever flakes across a WebKit bump, loosen to a ±1 band rather than deleting the guard.
…ighlight * origin/main: (27 commits) test(desktop): consolidate and stabilize scroll coverage (block#1815) fix(buzz-agent): support max effort for gpt-5.6 family (block#1806) fix(mobile): align Android AGP/Gradle/Kotlin with Flutter 3.41.7 (unbreak Android build) (block#1775) fix(desktop): widen probe test timing margins for parallel pre-push (block#1812) fix(desktop): keep pairing tests after production items (block#1807) chore(deps): update rust crate rand to v0.10.2 (block#1791) chore(deps): update rust crate nostr to v0.44.4 (block#1789) Add optional standalone pairing relay to Helm chart (block#1799) chore(deps): update radix-ui-primitives monorepo (block#1779) Fix mobile relay reconnect lifecycle (block#1772) fix(relay): publish membership snapshot on provisioning (block#1761) chore(ci): lint desktop Tauri crate in CI (block#1801) fix(desktop): preserve live events and window order across channel refreshes (block#1802) fix(desktop): restore macOS navigation chrome alignment (block#1797) chore(deps): update rust crate ignore to v0.4.28 (block#1788) fix(desktop): omit invalid snapshot imeta thumbnails (block#1800) fix(desktop): centralize known-agent trust set in useKnownAgentPubkeys (block#1703) chore(deps): update rust crate getrandom to v0.4.3 (block#1783) chore(deps): update rust crate arc-swap to v1.9.2 (block#1782) chore(deps): update all non-major dependencies (block#1778) ...
* origin/main: (230 commits) fix(snapshot): send Buzz shares as PNG avatar cards (block#1811) test(desktop): consolidate and stabilize scroll coverage (block#1815) fix(buzz-agent): support max effort for gpt-5.6 family (block#1806) fix(mobile): align Android AGP/Gradle/Kotlin with Flutter 3.41.7 (unbreak Android build) (block#1775) fix(desktop): widen probe test timing margins for parallel pre-push (block#1812) fix(desktop): keep pairing tests after production items (block#1807) chore(deps): update rust crate rand to v0.10.2 (block#1791) chore(deps): update rust crate nostr to v0.44.4 (block#1789) Add optional standalone pairing relay to Helm chart (block#1799) chore(deps): update radix-ui-primitives monorepo (block#1779) Fix mobile relay reconnect lifecycle (block#1772) fix(relay): publish membership snapshot on provisioning (block#1761) chore(ci): lint desktop Tauri crate in CI (block#1801) fix(desktop): preserve live events and window order across channel refreshes (block#1802) fix(desktop): restore macOS navigation chrome alignment (block#1797) chore(deps): update rust crate ignore to v0.4.28 (block#1788) fix(desktop): omit invalid snapshot imeta thumbnails (block#1800) fix(desktop): centralize known-agent trust set in useKnownAgentPubkeys (block#1703) chore(deps): update rust crate getrandom to v0.4.3 (block#1783) chore(deps): update rust crate arc-swap to v1.9.2 (block#1782) ...
Summary
x: 16,y: 24)Testing
pnpm exec playwright test tests/e2e/top-chrome-zoom-clearance.spec.ts tests/e2e/workspace-rail.spec.ts --project=smoke(9 passed)just ciattempted; blocked by a pre-existingorigin/mainRust 1.95 clippy failure atdesktop/src-tauri/src/commands/agent_discovery.rs:325(redundant_closure), outside this diff