Skip to content

test(desktop): harden observer archive policy regression coverage#1994

Merged
wpfleger96 merged 1 commit into
mainfrom
duncan/observer-archive-test-hardening
Jul 17, 2026
Merged

test(desktop): harden observer archive policy regression coverage#1994
wpfleger96 merged 1 commit into
mainfrom
duncan/observer-archive-test-hardening

Conversation

@wpfleger96

@wpfleger96 wpfleger96 commented Jul 16, 2026

Copy link
Copy Markdown
Member

Summary

Closes the review-coverage gaps left open when #1923 merged with production code verified defect-free but Thufir's pass-2 REQUEST CHANGES still outstanding on tests/bridge fidelity. No production reconciliation, Settings, or gate logic is touched — this is a tests/bridge-only change.

  • Bridge subscription state (saveSubscriptions) is now mutable: merge_save_subscription_kinds performs a real atomic kind-union (creating the row if absent), remove_save_subscription_kind removes a kind and deletes the row when empty. This mirrors the real merge_owner_p_kinds/remove_owner_p_kind Rust semantics instead of returning null over an immutable list.
  • New startup-barrier pair test: list_save_subscriptions call count is 0 while policy reconciliation is pending, >0 only after it resolves; stays 0 on policy rejection.
  • Settings toggle is asserted disabled while policy is unresolved and after fail-closed policy rejection, with no merge/remove command issued either way — closing the pass-1 CRITICAL fail-open race with a real regression instead of a synchronous-resolve test that never reaches the unresolved state.
  • Fresh-internal-repair test: internal policy + an empty saveSubscriptions list now shows a 24200 row is created after reconciliation — the actual production repair path the original bug report was about.
  • OSS toggle test now clicks ON and OFF, asserting list state transitions each way including the row-delete-when-empty edge.
  • useObserverArchiveSeed's reconciliation effect body is extracted into an exported startReconciliation() orchestration function that the hook's effect calls verbatim; identity-switch (A→B pending/failure/success) and unmount (pending/resolved) cancellation are tested directly against that function instead of a test-local re-implementation.
  • Removed the dead hasExplicitObserverArchiveChoice/clearExplicitObserverArchiveChoice/setExplicitObserverArchiveChoice marker APIs — nothing reads the marker at this head.

Related: #1923

Changed files

File Change
desktop/src/testing/e2eBridge.ts Mutable saveSubscriptions state cloned at install; real atomic merge/remove semantics; observerArchiveDefaultEnabledDelayMs/observerArchiveDefaultEnabledError knobs for policy pending/failure simulation.
desktop/tests/helpers/bridge.ts Added the new mock config options.
desktop/tests/e2e/observer-archive-policy.spec.ts New startup-barrier pair test, unresolved/failure Settings toggle tests, fresh-internal-repair test, OSS toggle ON/OFF test.
desktop/src/features/local-archive/useObserverArchiveSeed.ts Reconciliation effect body extracted into exported startReconciliation(); hook delegates to it directly.
desktop/src/features/local-archive/useObserverArchiveSeed.test.mjs Identity-switch and unmount cancellation tests now exercise startReconciliation() directly.
desktop/src/features/local-archive/ui/LocalArchiveSettingsCard.tsx Removed the now-unread setExplicitChoice call.
desktop/src/features/local-archive/observerArchivePreference.ts Deleted — dead marker APIs with zero callers.

@wpfleger96
test(desktop): harden observer archive policy regression coverage
9f73699 
Closes the review-identified coverage gaps left open when #1923 merged
production-verified but with Thufir's pass-2 REQUEST CHANGES still
outstanding on tests/bridge fidelity only:

- Mutable e2e bridge subscription state so merge/remove kind commands
  drive real state instead of no-op mocks (unlocks the fresh-install
  repair path and OSS toggle ON/OFF assertions).
- Startup-barrier pair test: list_save_subscriptions call count is 0
  while policy is pending, >0 only after it resolves.
- Settings toggle disabled while policy is unresolved and after
  fail-closed policy rejection; no merge/remove command issued either way.
- Reconciliation effect body extracted into startReconciliation() so
  identity-switch/unmount cancellation is tested against the real
  production lifecycle function rather than a re-implementation.
- Removed the dead hasExplicitObserverArchiveChoice/
  clearExplicitObserverArchiveChoice/setExplicitObserverArchiveChoice
  marker APIs — nothing reads them at this head.

Co-authored-by: Will Pfleger <pfleger.will@gmail.com>
Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
@wpfleger96
wpfleger96 requested a review from a team as a code owner July 16, 2026 21:21
@wpfleger96
wpfleger96 merged commit fd2eaac into main Jul 17, 2026
25 checks passed
@wpfleger96
wpfleger96 deleted the duncan/observer-archive-test-hardening branch July 17, 2026 16:10
atishpatel added a commit that referenced this pull request Jul 17, 2026
@atishpatel
Merge remote-tracking branch 'origin/main' into wren/client-metadata-…
cff7ee0 
…sanitize

* origin/main:
  [codex] Enforce shared relay admission limits (BUZZ-SEC-019) (#1917)
  [codex] Block banned actors from moderation commands (BUZZ-SEC-007) (#1915)
  [codex] Fix relay WebSocket admission limits (#1682)
  fix(desktop): close mention popup after an exact name + trailing space (#2030)
  test(desktop): harden observer archive policy regression coverage (#1994)
  [codex] Bind release publishers to immutable tags (BUZZ-SEC-039) (#1914)
@wesbillman wesbillman mentioned this pull request Jul 17, 2026
Merged
kalvinnchau added a commit that referenced this pull request Jul 17, 2026
@kalvinnchau
chore: merge origin/main
e6ee569 
* origin/main: (31 commits)
  chore(release): release Buzz Desktop version 0.4.14 (#2036)
  Strip media metadata on clients and reject it at the relay (#2006)
  fix(desktop): restore Doctor ACP login discovery (#2017)
  feat(desktop): animate starter team onboarding (#2032)
  fix(ci): use git diff for path filtering (#2029)
  fix(desktop): include exe dir and ~/.local/bin in provider discovery (#2007)
  [codex] Hold Git concurrency permits through streaming (BUZZ-SEC-018) (#1916)
  [codex] Enforce shared relay admission limits (BUZZ-SEC-019) (#1917)
  [codex] Block banned actors from moderation commands (BUZZ-SEC-007) (#1915)
  [codex] Fix relay WebSocket admission limits (#1682)
  fix(desktop): close mention popup after an exact name + trailing space (#2030)
  test(desktop): harden observer archive policy regression coverage (#1994)
  [codex] Bind release publishers to immutable tags (BUZZ-SEC-039) (#1914)
  fix: resolve invite downloads by platform (#2001)
  Bug-bash: mention/code-span, feed titles, autocomplete, edit-mentions, draft routing, and right-click media Download (#2027)
  fix(desktop): keep mesh allowlist on transient roster query failure (#2024)
  Polish Buzz theme and sidebar (#1971)
  Welcome new users with a live agent team kickoff (#1998)
  fix(desktop): case-insensitive relay media origin match, release 0.4.13 (#2023)
  feat(desktop): show owners in agent hover cards (#2015)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@wpfleger96