Skip to content

fix(desktop): restore public relay media previews in 0.4.12 #2014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baxen merged 1 commit into from
Jul 17, 2026
Merged

fix(desktop): restore public relay media previews in 0.4.12 #2014

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Changelog

## v0.4.12

- fix(desktop): proxy authenticated relay media after cold-start community initialization
- fix(desktop): keep shared-compute consumers admitted (WIP: multi-workspace publishing) ([#2000](https://github.com/block/buzz/pull/2000)) ([`5d77fa57`](https://github.com/block/buzz/commit/5d77fa57))
- feat(desktop): reskin provider, config, community, profile, and team onboarding pages ([#2003](https://github.com/block/buzz/pull/2003)) ([`f054df73`](https://github.com/block/buzz/commit/f054df73))


## v0.4.11

- Fix policy receipts for cold-launch invite links ([#2005](https://github.com/block/buzz/pull/2005)) ([`1d8d006a`](https://github.com/block/buzz/commit/1d8d006aaf078ffd5b92eae06334b7bb908b680e))
Expand Down
2 changes: 1 addition & 1 deletion desktop/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "buzz",
"private": true,
"version": "0.4.11",
"version": "0.4.12",
"type": "module",
"scripts": {
"dev": "vite",
Expand Down
2 changes: 1 addition & 1 deletion desktop/src-tauri/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion desktop/src-tauri/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

[package]
name = "buzz-desktop"
version = "0.4.11"
version = "0.4.12"
description = "Buzz desktop app"
authors = ["you"]
edition = "2021"
Expand Down
2 changes: 1 addition & 1 deletion desktop/src-tauri/tauri.conf.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"$schema": "https://schema.tauri.app/config/2",
"productName": "Buzz",
"version": "0.4.11",
"version": "0.4.12",
"identifier": "xyz.block.buzz.app",
"build": {
"beforeDevCommand": {
Expand Down
7 changes: 7 additions & 0 deletions desktop/src/features/communities/useCommunityInit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,13 @@ export function useCommunityInit(
}

if (!cancelled) {
// Refresh relay-derived media state only after the backend has installed
// this community's relay override. On cold launch, mediaUrl.ts may have
// eagerly cached the default relay origin before applyCommunity ran;
// leaving that stale value makes authenticated relay media look external
// and bypass the localhost proxy.
resetMediaCaches();

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Prime media origin before rendering previews

Because resetMediaCaches() clears cachedRelayOrigin and does not re-prime it before setResult({ isReady: true }), the first render after a cold launch runs rewriteRelayUrl() with no origin cached. In that state mediaUrl.ts intentionally rewrites any relay-shaped /media/<64-hex>... URL, so external Blossom media or media from another relay is fetched through the active relay/protocol and the resulting <img src> will stay wrong until some unrelated rerender. Please refresh the relay origin/port before marking the community ready, or avoid clearing the origin without starting a replacement fetch.

Useful? React with 👍 / 👎.

@brow brow Jul 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Real but narrow, and strictly better than the pre-PR behavior — not blocking. In the un-primed window rewriteRelayUrl() falls back to buzz-media://localhost/media/…, and the protocol handler resolves relay_api_base_url_with_override per request with minted Blossom auth, so own-relay media (the case this release fixes) renders correctly. The residual misroute is only for foreign-relay URLs that happen to match the /media/{64-hex} shape during the brief window before get_relay_http_url resolves — a fast sync IPC, and the same fall-through-when-unprimed default that existed before this PR. Worth a follow-up (e.g. await the origin before setResult({ isReady: true }), or have the proxy 404→pass-through on origin mismatch), but not a blocker for this release.


// Initialise the draft store for this identity so localStorage drafts
// are scoped to the correct pubkey before the app renders.
if (activeCommunity.pubkey) {
Expand Down