Skip to content

Improve agent runtime settings#2026

Open
klopez4212 wants to merge 5 commits into
mainfrom
kennylopez-doctor-status-cards
Open

Improve agent runtime settings#2026
klopez4212 wants to merge 5 commits into
mainfrom
kennylopez-doctor-status-cards

Conversation

@klopez4212

@klopez4212 klopez4212 commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • move runtime management into an Agent runtimes section under Settings → Agents
  • simplify runtime rows with logos, flat toggles, conditional overflow actions, and loading states
  • remove switch drop shadows across the app as an intentional shared-control update
  • prioritize Buzz Agent and Goose in the runtime list

Validation

  • pnpm check
  • pnpm run build
  • pnpm exec tsc --noEmit
  • runtime/settings Playwright coverage (12 passed)

The full pre-push suite could not finish because dependency downloads hit network timeouts and local disk exhaustion; PR CI is the final full-repository gate.

Snapshots

Agent runtimes

Agent runtimes

Runtime actions

Runtime actions

klopez4212 added a commit that referenced this pull request Jul 17, 2026
@klopez4212

Copy link
Copy Markdown
Contributor Author

🤖 Final UI snapshots

Agent runtimes

Runtime cards are grouped under Settings → Agents, with Buzz Agent and Goose first.

agent-runtimes-overview

Runtime actions

Setup and sign-in actions only appear when a runtime needs them.

agent-runtime-actions

@klopez4212
klopez4212 marked this pull request as ready for review July 17, 2026 13:05
@klopez4212
klopez4212 requested a review from a team as a code owner July 17, 2026 13:05
@klopez4212
klopez4212 marked this pull request as draft July 17, 2026 13:06

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e27923f258

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/settings/ui/DoctorSettingsPanel.tsx Outdated
Comment thread desktop/src/shared/ui/config-nudge-attachment.tsx
@klopez4212
klopez4212 marked this pull request as ready for review July 17, 2026 16:18

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e27923f258

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/settings/ui/DoctorSettingsPanel.tsx Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7352009c8d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/settings/ui/DoctorSettingsPanel.tsx
Comment thread desktop/src/features/settings/ui/DoctorSettingsPanel.tsx

@wpfleger96 wpfleger96 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a close pass at this — full-file reads at head e27923f2, with specific attention to whether the runtime-management move is behavior-preserving.

The migration plumbing is solid: legacy ?section=doctor deep-links redirect, the dropped doctor feature gate was a verified no-op (no entry in preview-features.json), the install path (per-runtime state, error surfacing, retry-via-toggle, query invalidation) survived intact, and the toggle gating exactly matches the old showInstall condition. The new installAcpRuntimeDelayMs test knob is a nice touch too.

Requesting changes for one functional regression in the sign-in flow (connect failures are now silent) plus a dropped terminal-login hint — both small, contained fixes in DoctorSettingsPanel.tsx. Also flagging that the switch.tsx shadow change is app-wide, and that degraded runtime states (adapter_outdated/cli_missing) are now indistinguishable from "not installed" at rest. Details inline.

Comment thread desktop/src/features/settings/ui/DoctorSettingsPanel.tsx Outdated
Comment thread desktop/src/features/settings/ui/DoctorSettingsPanel.tsx Outdated
Comment thread desktop/src/features/settings/ui/DoctorSettingsPanel.tsx
Comment thread desktop/src/shared/ui/switch.tsx
Comment thread desktop/src/features/settings/ui/DoctorSettingsPanel.tsx Outdated
Comment thread desktop/src/features/settings/ui/DoctorSettingsPanel.tsx
Comment thread desktop/src/features/settings/ui/DoctorSettingsPanel.tsx
Comment thread desktop/src/features/settings/ui/DoctorSettingsPanel.tsx Outdated
Comment thread desktop/src/shared/ui/config-nudge-attachment.tsx Outdated
Comment thread desktop/tests/e2e/doctor-states.spec.ts Outdated
@klopez4212
klopez4212 enabled auto-merge (squash) July 18, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants