Improve agent runtime settings#2026
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e27923f258
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e27923f258
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7352009c8d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
wpfleger96
left a comment
There was a problem hiding this comment.
Took a close pass at this — full-file reads at head e27923f2, with specific attention to whether the runtime-management move is behavior-preserving.
The migration plumbing is solid: legacy ?section=doctor deep-links redirect, the dropped doctor feature gate was a verified no-op (no entry in preview-features.json), the install path (per-runtime state, error surfacing, retry-via-toggle, query invalidation) survived intact, and the toggle gating exactly matches the old showInstall condition. The new installAcpRuntimeDelayMs test knob is a nice touch too.
Requesting changes for one functional regression in the sign-in flow (connect failures are now silent) plus a dropped terminal-login hint — both small, contained fixes in DoctorSettingsPanel.tsx. Also flagging that the switch.tsx shadow change is app-wide, and that degraded runtime states (adapter_outdated/cli_missing) are now indistinguishable from "not installed" at rest. Details inline.


Summary
Validation
pnpm checkpnpm run buildpnpm exec tsc --noEmitThe full pre-push suite could not finish because dependency downloads hit network timeouts and local disk exhaustion; PR CI is the final full-repository gate.
Snapshots
Agent runtimes
Runtime actions