Skip to content

fix(desktop): limit channel composer blur to input#2038

Merged
tlongwell-block merged 1 commit into
mainfrom
perci/fix-main-composer-overlay-blur
Jul 17, 2026
Merged

fix(desktop): limit channel composer blur to input#2038
tlongwell-block merged 1 commit into
mainfrom
perci/fix-main-composer-overlay-blur

Conversation

@tlongwell-block

Copy link
Copy Markdown
Collaborator

Summary

  • remove the full-width backdrop blur from the main channel composer overlay
  • retain blur on the inner message composer card
  • assert the overlay stays transparent while the composer remains blurred

Root cause

The main channel overlay acquired background and backdrop-blur classes in #1698, while the thread overlay stayed transparent. Since the shared MessageComposer already blurs its own card, the main channel rendered an extra full-width blurry strip around the composer.

Test plan

  • pnpm --dir desktop typecheck
  • pnpm --dir desktop exec biome check src/features/channels/ui/ChannelPane.tsx tests/e2e/channels.spec.ts
  • pnpm --dir desktop build
  • cd desktop && pnpm exec playwright test ./tests/e2e/channels.spec.ts --grep "channel date divider keeps the date sticky"
  • just desktop-screenshot --name compose-blur-fixed --route /channels/general --active-channel general (visually inspected)
  • pre-push hooks: desktop check/tests, mobile tests, Rust tests, desktop Tauri tests

@tlongwell-block
tlongwell-block requested a review from a team as a code owner July 17, 2026 18:16
Co-authored-by: npub1t2tgm7d8f995uqvmnm8h88sg3wnpp9a5xysjf6dg3tjmgt3ltulqdp8ehr <5a968df9a7494b4e019b9ecf739e088ba61097b4312124e9a88ae5b42e3f5f3e@sprout-oss.stage.blox.sqprod.co>
Signed-off-by: npub1t2tgm7d8f995uqvmnm8h88sg3wnpp9a5xysjf6dg3tjmgt3ltulqdp8ehr <5a968df9a7494b4e019b9ecf739e088ba61097b4312124e9a88ae5b42e3f5f3e@sprout-oss.stage.blox.sqprod.co>
@tlongwell-block
tlongwell-block force-pushed the perci/fix-main-composer-overlay-blur branch from fa57c9f to 54e0265 Compare July 17, 2026 19:04
@tlongwell-block

Copy link
Copy Markdown
Collaborator Author

Max review at current head 54e0265df: no blocking findings. The main-channel layering now matches MessageThreadPanel exactly: transparent outer overlay, shared blurred MessageComposer form, and opaque/non-blurred activity + typing row. The computed-style regression assertions cover all three layers. Independently verified pnpm build and the focused channels.spec.ts smoke test (1 passed). I could not submit a formal GitHub approval because the shared CLI identity owns this PR.

@tlongwell-block
tlongwell-block merged commit 0e03836 into main Jul 17, 2026
25 checks passed
@tlongwell-block
tlongwell-block deleted the perci/fix-main-composer-overlay-blur branch July 17, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant