Hide bundled harnesses from onboarding by morgmart · Pull Request #2233 · block/buzz

morgmart · 2026-07-21T16:50:17Z

Summary

show only Claude Code and Codex during onboarding; Buzz Agent and Goose remain available elsewhere in the app
treat harness cards as detected machine states instead of manual selections
guide each harness through Install → Sign in → Ready, with a Ready pill as the completion indicator
stop sign-in polling as soon as readiness is detected and offer Check again after a slow authentication timeout
automatically pass every ready, visible harness to the defaults page
auto-select the default when exactly one harness is ready; require an explicit choice when multiple are ready
make the defaults page the only onboarding surface where a preferred harness is chosen and persisted
wait for the latest default configuration to persist before completing onboarding
centralize onboarding harness visibility so hidden harnesses can be restored later in one place

Testing

pnpm typecheck
pnpm build:e2e
pnpm exec playwright test tests/e2e/onboarding-agent-defaults.spec.ts --project=smoke — 15 passed
node --import ./test-loader.mjs --experimental-strip-types --test src/features/onboarding/ui/onboardingRuntimeSelection.test.mjs — 4 passed
node --import ./test-loader.mjs --experimental-strip-types --test src/features/onboarding/ui/saveCoalescer.test.mjs — 9 passed
pnpm exec playwright test tests/e2e/onboarding-docked-cta-screenshots.spec.ts --project=smoke — 3 passed
targeted Biome checks passed

wpfleger96

I’m okay keeping the broader Install → Sign in → Ready redesign, moving preferred-harness selection to the defaults page, and auto-selecting when only one visible harness is ready, as long as these are treated as intentional onboarding UX changes rather than necessary fallout from hiding two harnesses. The centralized Claude/Codex onboarding allowlist is the right boundary. The latest commits also resolve the sign-in polling issue I found by clearing the wait state once the catalog reports Ready.

I’m requesting changes for the prerequisite regression, the lost acceptance coverage, and the save race below. I also left one boundary-test request and one non-blocking cleanup comment.

bradseiler · 2026-07-21T18:22:33Z

  ]);

+  React.useEffect(() => {
+    onHasDefaultRuntimeChange(selectedRuntimeId.length > 0);


🤖 Should Finish wait until the default harness save has succeeded? This state flips from the optimistic selected runtime, but the actual setGlobalAgentConfig save is queued asynchronously and errors are swallowed, so onboarding can complete with preferred_runtime still null or stale.

Updated by Codex 🤖

🤖 Addressed in 75599d3. Finish now remains disabled while persistence is draining, awaits the latest coalesced save before completing, and keeps the user on the page with a retryable error if persistence fails. Added flush success/failure unit coverage and a delayed rapid-toggle E2E regression.

bradseiler · 2026-07-21T18:22:36Z

-  const runtimeSaveChain = React.useRef<Promise<void>>(Promise.resolve());
-
-  const persistHarnessSelection = React.useCallback(
+  const [readyRuntimeIds, setReadyRuntimeIds] = React.useState<string[]>([]);


🤖 Should this be seeded when the flow starts directly on the config page? reopenMachineConfig can mount MachineOnboardingFlow with initialPage="config", so Setup never reports ready IDs; this stays empty, the harness dropdown has no options, and Finish remains disabled until the user goes Back through setup.

Updated by Codex 🤖

🤖 Addressed in 8a584a6. When the flow mounts directly on the config page without a Setup handoff, the defaults page now derives ready visible runtime IDs from the settled runtime catalog. The normal Setup handoff still takes precedence. Extended the existing first-community Back regression to verify the sole ready harness is selected and Finish is enabled.

wpfleger96

Re-reviewed the latest head 8a584a60e. The persistence race and direct-config reopening path are fixed with regression coverage; the focused onboarding suite restores the meaningful acceptance coverage; the existing Doctor smoke test pins Goose and Buzz Agent outside onboarding; and the PR summary now matches the Ready-pill UX. Accepting the Git Bash removal as the intentional product-scope decision described in the thread.

…cache * origin/main: feat(desktop): fuzzy emoji shortcode autocomplete (#1945) Revert "feat(relay): inventory unreachable Git objects" (#2275) feat(relay): inventory unreachable Git objects (#2264) Keep avatar preview visible during upload (#2237) fix(desktop): keep machine onboarding for unrecognized identities after reset (#2244) fix(managed-agents): stale harness pin shadows runtime edits; add Restart quick action (#2252) fix(desktop): surface model discovery failures in agent config UI (#2246) Hide bundled harnesses from onboarding (#2233) relay: add author_type label to buzz_events_stored_total (#2243) fix(justfile): use Hermit-pinned lefthook in hooks recipe (#2241) Refresh README screenshots (#2236) fix(acp): pace relay observer frames (6/s + 90/min, zero burst) (#2217) Restore npub copy option for private community joins (#2232) fix(desktop): align onboarding runtime auth (#2229) fix(desktop): survive degraded networks with rate-limit-aware relay client (#2197) fix(cli): retry transient relay failures and raise timeouts (#2196) feat(desktop): browse immutable repository tags (#2231) Update built-in agent avatars (#2215) cleanup old AI doc (#2227) chore(release): release Buzz Mobile version 0.4.11 (#2225)

* origin/main: (24 commits) feat(relay): log NIP-98 pubkey attribution on HTTP bridge requests (block#2206) fix(ci): don't rebuild relay tests on every run (block#2203) fix(desktop): refresh cached channel member names (block#2258) chore(release): release Buzz Desktop version 0.4.22 (block#2220) feat(desktop): fuzzy emoji shortcode autocomplete (block#1945) Revert "feat(relay): inventory unreachable Git objects" (block#2275) feat(relay): inventory unreachable Git objects (block#2264) Keep avatar preview visible during upload (block#2237) fix(desktop): keep machine onboarding for unrecognized identities after reset (block#2244) fix(managed-agents): stale harness pin shadows runtime edits; add Restart quick action (block#2252) fix(desktop): surface model discovery failures in agent config UI (block#2246) Hide bundled harnesses from onboarding (block#2233) relay: add author_type label to buzz_events_stored_total (block#2243) fix(justfile): use Hermit-pinned lefthook in hooks recipe (block#2241) Refresh README screenshots (block#2236) fix(acp): pace relay observer frames (6/s + 90/min, zero burst) (block#2217) Restore npub copy option for private community joins (block#2232) fix(desktop): align onboarding runtime auth (block#2229) fix(desktop): survive degraded networks with rate-limit-aware relay client (block#2197) fix(cli): retry transient relay failures and raise timeouts (block#2196) ...

> [!NOTE] > **Part 1 of a multi-PR onboarding rework.** This PR only restores the hidden harnesses, adjusts the card layout, and gates onboarding completion on valid config. A follow-up PR (stacked on this branch) restructures the flow: the harness page becomes a single-choice "pick your default harness" step, and install/sign-in/provider setup moves to the following page. Review this one on its own terms — the flow rework is intentionally not here. ## Summary - Restore **Goose** and **Buzz Agent** to onboarding harness selection, reverting the launch-only restriction from #2233 - The restore is the single centralized allowlist (`ONBOARDING_RUNTIME_ORDER` in `onboardingRuntimeSelection.ts`) that #2233 deliberately set up for this moment — setup cards, readiness handoff, and the defaults harness picker all derive from it - Lay the four harness cards out as a single row at `lg` and above (`lg:grid-cols-4`); below 1024px (including the app's 800px minimum window width) the grid is 2×2, and 1-up on narrow viewports - **Gate onboarding Finish on actual config validity** (review finding): the defaults page rendered provider/model/credential fields for provider-required harnesses but Finish only checked that a harness was selected — a fresh user picking Buzz Agent could persist a default that fails at first spawn. The Finish gate now consumes `AgentConfigFields`' existing `onValidityChange` signal. Baked build env and runtime-file config satisfy the gate, so internal builds and existing Goose users are never blocked - Update the unit + E2E specs that pinned the hidden behavior, plus two new E2E cases pinning the Finish gate (blocked-until-configured, and baked-env never blocked) - AGENTS.md rule 7 updated to document the completion gate ## Testing - `onboardingRuntimeSelection.test.mjs` — 4 passed - `pnpm typecheck` — clean - `pnpm exec playwright test tests/e2e/onboarding-agent-defaults.spec.ts --project=smoke` — 21 passed - `onboarding-docked-cta-screenshots.spec.ts` — 3 passed - Biome — clean ## Known cosmetic issue (deferred to PR 2) At the app's minimum window size (800×500) the 2×2 grid extends past the visible area and the footer CTA overlaps card space. Next still hit-tests correctly. PR 2 redesigns this page entirely (cards become a single-choice chooser with no inline setup), so this is deferred rather than patched twice. --------- Signed-off-by: morgmart <98432065+morgmart@users.noreply.github.com>

Hide bundled harnesses from onboarding

4277bb3

morgmart requested a review from a team as a code owner July 21, 2026 16:50

morgmart added 8 commits July 21, 2026 10:16

Detect harness readiness during onboarding

2fc936e

Test onboarding harness readiness flow

201e33f

Trust onboarding readiness handoff

bee0588

Hide onboarding readiness checkmark

f3be775

Update onboarding screenshot heading

6afed8f

Update readiness tests for hidden checkmark

f9dcc59

Stop completed sign-in polling

0bff8bb

Auto-select sole onboarding harness

78a394b

wpfleger96 requested changes Jul 21, 2026

View reviewed changes

torstenrudolf approved these changes Jul 21, 2026

View reviewed changes

bradseiler reviewed Jul 21, 2026

View reviewed changes

morgmart added 2 commits July 21, 2026 11:25

Harden onboarding defaults persistence

75599d3

Seed direct onboarding config readiness

8a584a6

wpfleger96 approved these changes Jul 21, 2026

View reviewed changes

morgmart enabled auto-merge (squash) July 21, 2026 18:51

morgmart merged commit 50f4412 into main Jul 21, 2026
26 checks passed

morgmart deleted the remove-buzz-goose-onboarding branch July 21, 2026 18:54

tzarebczan mentioned this pull request Jul 21, 2026

[Bug] Windows: Codex model discovery times out / empty models (cold start >10s) #2261

Open

This was referenced Jul 21, 2026

fix(desktop): keep model settings populated when onboarding reopens #2249

Closed

chore(release): release Buzz Desktop version 0.4.22 #2220

Merged

morgmart mentioned this pull request Jul 24, 2026

Restore Goose and Buzz Agent to onboarding harness selection #2731

Merged

bitcoinaudio mentioned this pull request Jul 27, 2026

Desktop onboarding hides the bundled Buzz Agent harness — no visible local/no-cloud path at first run #3173

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Hide bundled harnesses from onboarding - #2233

Hide bundled harnesses from onboarding#2233
morgmart merged 11 commits into
mainfrom
remove-buzz-goose-onboarding

morgmart commented Jul 21, 2026 •

edited

Loading

Uh oh!

wpfleger96 left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bradseiler Jul 21, 2026

Uh oh!

morgmart Jul 21, 2026

Uh oh!

bradseiler Jul 21, 2026

Uh oh!

morgmart Jul 21, 2026

Uh oh!

wpfleger96 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

morgmart commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Uh oh!

wpfleger96 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bradseiler Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

morgmart Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

bradseiler Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

morgmart Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

wpfleger96 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

morgmart commented Jul 21, 2026 •

edited

Loading

wpfleger96 left a comment •

edited

Loading