fix(workflows): authorize trusted owner-only agent wakeups - #3498
Closed
JustinPerea wants to merge 1 commit into
Closed
fix(workflows): authorize trusted owner-only agent wakeups#3498JustinPerea wants to merge 1 commit into
JustinPerea wants to merge 1 commit into
Conversation
Co-authored-by: Justin Perea <justinmperea@gmail.com> Signed-off-by: Justin Perea <justinmperea@gmail.com>
Author
|
@tlongwell-block could you review this relay/ACP authorization fix? It keeps agents owner-only while accepting workflow ownership only after NIP-11 signer, event signature, kind, and exact actor/workflow tag verification. Full local |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buzz-acponly when the relay identity, eventsignature, kind, and exact workflow tags all verify
modes, while keeping managed agents in
owner-onlySecurity model
Untrusted authors cannot self-assert an
actortag.buzz-acpaccepts theeffective workflow owner only when:
["buzz:workflow", "true"]tag is presentactortag is presentMissing metadata, malformed tags, duplicate tags, wrong kinds, forged signers,
and tampered events all fall back to the literal event signer and therefore
remain rejected by
owner-only.Verification
just cipassedcargo test -p buzz-acp --lib: 636 passedcargo test -p buzz-relay --lib workflow_base_tags_include_actor_and_legacy_attribution: passedjust testcompleted its unit phase, but its integration bootstrap could notstart because Docker Desktop was not running. A direct full
cargo test -p buzz-relay --librun produced 762 passes and 10database/mesh-environment failures, plus 33 ignored tests.
Deployment
The relay and ACP harness must both be deployed before scheduled
owner-onlyagent wakeups begin working. Deployment order is safe because either partial
state remains fail-closed.
Buzz origin channel:
965eb307-5e3b-4f4e-a9c6-94323d98982d