Skip to content

desktop: restore direct community member adds - #3634

Merged
wesbillman merged 7 commits into
mainfrom
carl/restore-community-direct-add
Jul 30, 2026
Merged

desktop: restore direct community member adds#3634
wesbillman merged 7 commits into
mainfrom
carl/restore-community-direct-add

Conversation

@wesbillman

@wesbillman wesbillman commented Jul 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • restore direct community member adds in Settings → Invites
  • keep one consolidated entry point: the dialog now supports both adding someone directly and sharing an invite link
  • accept npub or 64-character hex keys while preserving role hierarchy (owners: Member/Admin; admins: Member only)
  • verify an npub direct-add publishes the decoded hex key in a kind 9030 NIP-IA event

Why

The Invites consolidation left AddMemberDialog without a live mount point, so the existing direct-add capability disappeared even though its mutation path still existed. This reuses that implementation rather than introducing a second one.

Before and after

Before After
The consolidated dialog only offered a share link; there was no direct-add path. The same dialog now presents direct add and share-link controls as one invitation flow.
Before: invite dialog with share-link controls only After: polished community invite dialog with direct-add and share-link sections
Before: Invites page entry point

Before: Invites settings page

Verification

  • pnpm --dir desktop build:e2e
  • pnpm exec playwright test tests/e2e/invites-settings-screenshots.spec.ts --project=smoke — 4 passed
  • targeted Biome check on modified files
  • push hook: Desktop check and 3,783 Desktop tests passed
  • GitHub CI green except Desktop E2E Relay still running at last status snapshot

joahg and others added 2 commits July 29, 2026 16:06
@joahg @ampagent npub1cl47vfhsqpqy9pwndphpm36vcp7vvz5h2js4qpqm5yewzj7nutkq7xyw8c
desktop: accept npub or hex pubkey when adding members
f62b5d0 
The relay Add Member dialog only accepted a 64-char hex pubkey and
rejected npub input. The channel member picker was search-only, so a
user without a kind:0 profile on the relay could not be invited at all.

Add parsePubkeyInput (hex or npub1 -> lowercase hex) to nostrUtils and
use it in both surfaces: the relay dialog now takes either form, and
the channel picker offers an 'add by public key' row when the query
parses as a pubkey that is not already a member, selected, or found
by search.

Signed-off-by: Joah Gerstenberg <joah@squareup.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019faf86-3f26-75b8-87de-08ff05a0b686
Co-authored-by: Amp <amp@ampcode.com>
@wesbillman Carl
desktop: restore direct community member adds
125a7aa 
Expose the existing npub/hex direct-add flow inside the consolidated
community invite dialog alongside shareable links. Preserve role gating
so owners can add members or admins while admins can only add members.

Add an end-to-end assertion that npub input is decoded into the expected
NIP-IA admin event.

Co-authored-by: Carl <c7ebe626f000404285d3686e1dc74cc07cc60a9754a150041ba132e14bd3e2ec@buzz.block.builderlab.xyz>
Signed-off-by: Wes <wesbillman@users.noreply.github.com>
@wesbillman
wesbillman requested a review from a team as a code owner July 29, 2026 22:14
wesbillman and others added 3 commits July 29, 2026 16:22
@wesbillman Carl
Polish the community invite dialog
232c076 
Give direct-add and invite-link flows clearer hierarchy, richer role controls,
and a scroll-safe responsive layout. Cover admin role gating on the live
Invites surface.

Co-authored-by: Carl <c7ebe626f000404285d3686e1dc74cc07cc60a9754a150041ba132e14bd3e2ec@buzz.block.builderlab.xyz>
Signed-off-by: Wes <wesbillman@users.noreply.github.com>
@wesbillman Carl
Normalize invite dialog screenshot focus
86f948a 
Move pointer focus away from the expiry control before capturing the dialog so
the screenshot represents its default visual state.

Co-authored-by: Carl <c7ebe626f000404285d3686e1dc74cc07cc60a9754a150041ba132e14bd3e2ec@buzz.block.builderlab.xyz>
Signed-off-by: Wes <wesbillman@users.noreply.github.com>
@klopez4212
desktop: refine community invite flow
a1ed382 
Signed-off-by: kenny lopez <klopez4212@gmail.com>
klopez4212 added a commit that referenced this pull request Jul 30, 2026
@klopez4212
screenshots: PR #3634
8e8baa1
@klopez4212
desktop: align recipient chip padding
228cdb2 
Signed-off-by: kenny lopez <klopez4212@gmail.com>
@klopez4212

klopez4212 commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

🤖 Updated invite flow snapshot — aligned recipient chip spacing.

02-invite-dialog

klopez4212 added a commit that referenced this pull request Jul 30, 2026
@klopez4212
screenshots: PR #3634
cc948e9
@klopez4212
desktop: match community invite action height
958f7dc 
Signed-off-by: kenny lopez <klopez4212@gmail.com>
@wesbillman
wesbillman merged commit 310df2e into main Jul 30, 2026
26 checks passed
@wesbillman
wesbillman deleted the carl/restore-community-direct-add branch July 30, 2026 14:04
wpfleger96 added a commit that referenced this pull request Jul 30, 2026
@wpfleger96
Merge remote-tracking branch 'origin/main' into duncan/agent-usage-ar…
55dabfd 
…chive

* origin/main: (22 commits)
  feat(catalog): resolve publisher display name in catalog detail pane (#3640)
  feat(mesh): upgrade embedded mesh to v0.74 and harden shared compute (split 1/2 of #3467) (#3741)
  docs(nips): specify kind:30621 multi-repo projects (NIP-MP) (#3163)
  Refine agent sharing dialog (#3699)
  desktop: enable getUserMedia in the Linux WebKitGTK webview (#3607)
  fix: align responsive agent views (#3688)
  Add macOS agent menu-bar menu (#3565)
  Fix pending message feedback (#3543)
  fix(desktop): remove remaining Projects panel fills (#3742)
  feat(mobile): desktop-parity emoji and thread experience (#3485)
  desktop: restore direct community member adds (#3634)
  fix(desktop): explain open agent access (#2561)
  fix(cli): resolve agents from owner records (#3178)
  fix(desktop): remove Projects overview card fills (#3416)
  feat(replica): portable heartbeat-token fence with snapshot-local reader routing (#3268)
  fix(git): channel binding tooling + author remediation for unbound repos (#3626)
  feat: configure S3 URL addressing style (#3400)
  feat: add first-class OpenRouter provider support (#1975)
  feat(agent,acp): wire provider total_tokens through NIP-AM publish chain (#3593)
  chore(release): release Buzz Desktop version 0.5.2 (#3624)
  ...

Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
wpfleger96 pushed a commit that referenced this pull request Jul 30, 2026
npub1mn7jgtj4w2pd0g0zeuhxsa6jy6p0rewxz4kujt98my82ahfmp72sxjexk7
Merge remote-tracking branch 'origin/main' into duncan/install-ceilin…
93ccd19 
…g-pipeline

* origin/main: (25 commits)
  Refine agent sharing dialog (#3699)
  desktop: enable getUserMedia in the Linux WebKitGTK webview (#3607)
  fix: align responsive agent views (#3688)
  Add macOS agent menu-bar menu (#3565)
  Fix pending message feedback (#3543)
  fix(desktop): remove remaining Projects panel fills (#3742)
  feat(mobile): desktop-parity emoji and thread experience (#3485)
  desktop: restore direct community member adds (#3634)
  fix(desktop): explain open agent access (#2561)
  fix(cli): resolve agents from owner records (#3178)
  fix(desktop): remove Projects overview card fills (#3416)
  feat(replica): portable heartbeat-token fence with snapshot-local reader routing (#3268)
  fix(git): channel binding tooling + author remediation for unbound repos (#3626)
  feat: configure S3 URL addressing style (#3400)
  feat: add first-class OpenRouter provider support (#1975)
  feat(agent,acp): wire provider total_tokens through NIP-AM publish chain (#3593)
  chore(release): release Buzz Desktop version 0.5.2 (#3624)
  docs: add Linux rendering troubleshooting guide (#3573)
  fix(desktop): discover bun-installed agent CLIs in ~/.bun/bin (#3343)
  feat(tracing): correlate trace IDs in relay logs (#3608)
  ...

Signed-off-by: npub1mn7jgtj4w2pd0g0zeuhxsa6jy6p0rewxz4kujt98my82ahfmp72sxjexk7 <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz>
joahg added a commit to joahg/buzz-dev-mode that referenced this pull request Jul 30, 2026
@joahg
Merge remote-tracking branch 'origin/main' into joah/dev-mode-display…
d51baaa 
…-style

* origin/main:
  fix(acp): preserve truncated thread context (block#3340)
  feat(catalog): resolve publisher display name in catalog detail pane (block#3640)
  feat(mesh): upgrade embedded mesh to v0.74 and harden shared compute (split 1/2 of block#3467) (block#3741)
  docs(nips): specify kind:30621 multi-repo projects (NIP-MP) (block#3163)
  Refine agent sharing dialog (block#3699)
  desktop: enable getUserMedia in the Linux WebKitGTK webview (block#3607)
  fix: align responsive agent views (block#3688)
  Add macOS agent menu-bar menu (block#3565)
  Fix pending message feedback (block#3543)
  fix(desktop): remove remaining Projects panel fills (block#3742)
  feat(mobile): desktop-parity emoji and thread experience (block#3485)
  desktop: restore direct community member adds (block#3634)
  fix(desktop): explain open agent access (block#2561)
  fix(cli): resolve agents from owner records (block#3178)
  fix(desktop): remove Projects overview card fills (block#3416)
  feat(replica): portable heartbeat-token fence with snapshot-local reader routing (block#3268)

Signed-off-by: Joah Gerstenberg <joah@squareup.com>
wpfleger96 added a commit that referenced this pull request Jul 30, 2026
@wpfleger96
Merge remote-tracking branch 'origin/main' into duncan/acp-resume-ledger
328c736 
* origin/main: (59 commits)
  Fix video reviews in thread replies (#3719)
  feat(release): make desktop releases immutable (#3568)
  Make relay reconnect backoff authoritative (#3774)
  feat(desktop): add password-protected backups in settings (#3701)
  fix(desktop): reuse profiles when joining communities (#2155)
  Render mobile agent mention chips (#3702)
  fix(catalog): update Amp description (#3758)
  fix(acp): preserve truncated thread context (#3340)
  feat(catalog): resolve publisher display name in catalog detail pane (#3640)
  feat(mesh): upgrade embedded mesh to v0.74 and harden shared compute (split 1/2 of #3467) (#3741)
  docs(nips): specify kind:30621 multi-repo projects (NIP-MP) (#3163)
  Refine agent sharing dialog (#3699)
  desktop: enable getUserMedia in the Linux WebKitGTK webview (#3607)
  fix: align responsive agent views (#3688)
  Add macOS agent menu-bar menu (#3565)
  Fix pending message feedback (#3543)
  fix(desktop): remove remaining Projects panel fills (#3742)
  feat(mobile): desktop-parity emoji and thread experience (#3485)
  desktop: restore direct community member adds (#3634)
  fix(desktop): explain open agent access (#2561)
  ...

# Conflicts:
#	desktop/scripts/check-file-sizes.mjs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wesbillman @klopez4212 @joahg