fix(desktop): show shared invocable agents in mentions - #4242
Open
bluestonetrust wants to merge 5 commits into
Open
fix(desktop): show shared invocable agents in mentions#4242bluestonetrust wants to merge 5 commits into
bluestonetrust wants to merge 5 commits into
Conversation
added 4 commits
August 2, 2026 13:37
Include relay agents that the current user can invoke through a shared channel or allowlist while continuing to hide unavailable agent identities. Keep duplicate agent entries coalesced and cover the picker and outbound mention flow with unit and browser tests. Co-authored-by: Khanh Le <bluestonetrust04@gmail.com> Signed-off-by: Khanh Le <bluestonetrust04@gmail.com>
Co-authored-by: Khanh Le <bluestonetrust04@gmail.com> Signed-off-by: Khanh Le <bluestonetrust04@gmail.com>
Co-authored-by: Khanh Le <bluestonetrust04@gmail.com> Signed-off-by: Khanh Le <bluestonetrust04@gmail.com>
Pass the known forum channel type only from forum-backed composers so other ForumComposer reuse stays fail closed. Strengthen the DM and unresolved-state browser controls and cover relay-only forum autocomplete. Co-authored-by: Khanh Le <bluestonetrust04@gmail.com> Signed-off-by: Khanh Le <bluestonetrust04@gmail.com>
bluestonetrust
marked this pull request as ready for review
August 2, 2026 04:20
bluestonetrust
marked this pull request as draft
August 3, 2026 05:06
Require relay agents to be invocable in the exact stream or forum being composed. Keep DMs and context-free pickers fail closed, revalidate cached suggestions, and prevent relay identities from reappearing as people. Co-authored-by: OpenAI <support@openai.com> Signed-off-by: Khanh Le <bluestonetrust04@gmail.com>
bluestonetrust
marked this pull request as ready for review
August 3, 2026 05:42
wesbillman
added a commit
that referenced
this pull request
Aug 5, 2026
## Summary - admit relay-discovered agents to autocomplete when their response policy authorizes the viewer - require authorization in the exact active stream/forum channel for mentions, while keeping community-wide discovery for member invitation - fail closed for relay-only agents in DMs and unresolved composer contexts - re-authorize cached autocomplete rows after policy/channel changes so stale agent suggestions cannot leak back in - preserve managed-agent behavior and explicitly reject stale agent-marked channel members absent from both live directories ## Validation - `pnpm --dir desktop test` — 4,288 passed - `pnpm --dir desktop typecheck` - `pnpm --dir desktop check` - `pnpm --dir desktop build:e2e` - focused Playwright mention matrix — 12 passed - focused Playwright member-invitation matrix — 2 passed - pre-push hooks after rebase to current `origin/main` — desktop check and 4,288 tests passed - independent correctness/privacy re-review cleared with no remaining blocker ## Related competing PRs This supersedes or overlaps #2333, #3056, #4242, #4137, #2314, #4058, and #2605. This version adds exact-channel authorization, fail-closed DM/context handling, cached-row reauthorization, forum coverage, outbound mention-tag coverage, explicit stale-member coverage, and add-member discovery coverage. Signed-off-by: Wes <wesbillman@users.noreply.github.com> Co-authored-by: Carl <c7ebe626f000404285d3686e1dc74cc07cc60a9754a150041ba132e14bd3e2ec@buzz.block.builderlab.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
respond_topolicy permits the current viewerptags and forum mention supportRoot cause
Desktop treated relay-agent eligibility as profile-wide. An allowlisted agent could be suggested without belonging to the active channel, while an
anyoneagent could be suggested because it overlapped some other joined channel. That exposed identities and advertised actions that ACP would not dispatch.Security and privacy
The picker now requires all of these for an other-owned relay agent:
channel_idscontains that exact channelrespond_toisanyone, or the current viewer is explicitly allowlistedDMs remain managed-only because ACP's DM author gate permits only the owner or same-owner sibling agents. Cached suggestions are rechecked against current eligible candidates before display.
Validation
pnpm test: 3,905 passed, 0 failedpnpm check: passedpnpm build: passedpnpm build:e2e: passedplaywright tests/e2e/mentions.spec.ts: 54 passedp-tag coverage: passedaarch64-apple-darwinTauri app bundle: built successfullyFixes #3971
Originating Buzz channel:
1e408238-c672-4d83-ab5c-25ff3f7401eb