Fix/desktop repo files truncation 4428 - #4497
Closed
tagadearpit wants to merge 2 commits into
Closed
Conversation
The Files tab silently truncated tree listings at 250 entries and presented the truncated list as complete. Raise the soft cap and name the constant so typical repos (including the reported 661-file case) render fully while still bounding memory on huge monorepos. Fixes block#4428 Signed-off-by: Arpit Tagade <tagadearpit@users.noreply.github.com>
The Files tab silently truncated tree listings at 250 entries and presented the truncated list as complete. Raise the soft cap and name the constant so typical repos (including the reported 661-file case) render fully while still bounding memory on huge monorepos. Fixes block#4428 Signed-off-by: Arpit Tagade <tagadearpit@users.noreply.github.com>
Contributor
|
this drops a large chunk of project_git.rs (~600 lines) while only raising the 250 cap. #4499 looks like the fuller fix — discloses truncation instead of silently deleting snapshot helpers. please confirm the deletions were intentional and not a bad rebase. |
Author
|
You're right — the ~600-line deletion was not intentional. It was a truncated push of project_git.rs, not a deliberate design choice. |
Contributor
|
raising the hard cap helps, but #4499's total_file_count disclosure is clearer for huge trees — might want to align with that. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issue
Testing