fix(desktop): hide selection formatting tray on composer right-click

[matt2e]

Summary

Right-clicking a text selection in the message composer left the selection formatting tray floating over the native context menu. This suppresses the tray for the duration of the right-click interaction.

Changes

• SelectionFormattingTray.tsx: a contextmenu listener on the editor DOM sets a suppression ref, cancels any queued rAF reposition, and hides the tray. Suppression clears on the next left-click pointerdown or keydown in the editor, which reschedules a normal position update.
• scheduleUpdate/updatePosition both honor the suppression ref, so editor selectionUpdate/transaction/focus events fired during the right-click can't bring the tray back.
• Extracted cancelScheduledUpdate to replace the duplicated rAF-cancel logic, and reset suppression on editor change / cleanup.
• E2E coverage in composer-selection-formatting.spec.ts: double-click to select, assert the tray shows, right-click and assert the tray hides and that contextmenu is not defaultPrevented (the native menu still opens), then re-select and assert the tray returns.

Testing

just pre-push gate ran green: desktop-check, desktop-typecheck, desktop-test (5397 passing), file-size-check.

Demo

video.mp4

[wesbillman]

Carl, an automated reviewer, commenting via Wes’s GitHub account.

Reviewed exact head ab4cef455bd61d2a62505de1ac4c44faec0818c7 against base 0720f5380ce8a6c050afac159f8462c06cd51ab5. No actionable defects found.

I traced the full interaction lifecycle: native mouse right-click, queued editor selection/transaction/focus updates, primary-pointer and editor-key recovery, keyboard context-menu ordering, editor replacement/unmount, and listener/RAF cleanup. The synchronous suppression ref prevents queued updates from resurrecting the tray, and cleanup removes listeners from the captured editor DOM without changing focus, selection, or native context-menu default behavior.

Validation: the focused smoke E2E for this regression passed at the exact head and asserts tray hide, contextmenu.defaultPrevented === false, and primary-pointer recovery. git diff --check also passed. Desktop Core, smoke E2E shards, integration E2E, macOS build, aggregate Desktop, and DCO checks are green.

Residual risk: the new E2E directly covers mouse right-click and primary-pointer recovery; keyboard invocation and editor replacement are verified from event ordering and cleanup paths rather than dedicated runtime cases.