fix(desktop): show an agent in @ search after you add it to a channel - #7192
Draft
loganj wants to merge 2 commits into
Draft
fix(desktop): show an agent in @ search after you add it to a channel#7192loganj wants to merge 2 commits into
loganj wants to merge 2 commits into
Conversation
Collaborator
Author
|
🤖 Before: preceding prefix cannot find the agent in Add membersActual After: Add succeeds and the first @ picker includes the agentActual |
loganj
force-pushed
the
fix/mention-picker-stack-844abd33-2
branch
from
September 2, 2026 02:15
2134900 to
bef4896
Compare
loganj
force-pushed
the
fix/mention-picker-stack-844abd33-3
branch
from
September 2, 2026 02:15
c0da14c to
01d4c85
Compare
loganj
force-pushed
the
fix/mention-picker-stack-844abd33-2
branch
from
September 2, 2026 16:06
bef4896 to
9164074
Compare
loganj
force-pushed
the
fix/mention-picker-stack-844abd33-3
branch
from
September 2, 2026 16:06
01d4c85 to
8d9aded
Compare
loganj
force-pushed
the
fix/mention-picker-stack-844abd33-2
branch
from
September 4, 2026 11:17
9164074 to
b411da5
Compare
loganj
force-pushed
the
fix/mention-picker-stack-844abd33-3
branch
from
September 4, 2026 11:17
07fbd2c to
a304f09
Compare
This was referenced Sep 4, 2026
loganj
force-pushed
the
fix/mention-picker-stack-844abd33-3
branch
from
September 8, 2026 17:26
a304f09 to
e3fa528
Compare
loganj
force-pushed
the
fix/mention-picker-stack-844abd33-2
branch
2 times, most recently
from
September 8, 2026 17:31
4316a13 to
e647e70
Compare
loganj
force-pushed
the
fix/mention-picker-stack-844abd33-3
branch
from
September 8, 2026 17:31
e3fa528 to
b91a0d1
Compare
loganj
force-pushed
the
fix/mention-picker-stack-844abd33-2
branch
from
September 8, 2026 17:36
e647e70 to
96c6d9c
Compare
loganj
force-pushed
the
fix/mention-picker-stack-844abd33-3
branch
from
September 8, 2026 17:36
b91a0d1 to
1f02608
Compare
…nges Co-authored-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz> Signed-off-by: Logan Johnson <loganj@squareup.com>
The independent extraction of this PR removed the fixed-root Welcome sequence that submits an ambiguous typed mention and asserts the visible error, the preserved draft, the still-prompt banner and no published event. Those assertions are baseline negative coverage for this suite, not newly owned recovery evidence, so they are restored after the new roster-freshness wait and before the unchanged exact-current-starter selection. The production fix for the visible failure is the independent composer recovery work; until it lands, this journey is expected to fail on the fixed root, and no green claim is made for it here. Co-authored-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz> Signed-off-by: Logan Johnson <loganj@squareup.com>
loganj
force-pushed
the
fix/mention-picker-stack-844abd33-3
branch
from
September 8, 2026 18:23
ff11ed1 to
235d261
Compare
loganj
force-pushed
the
fix/mention-picker-stack-844abd33-2
branch
from
September 8, 2026 18:23
96c6d9c to
ff2b68c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


🤖
Summary
Makes a newly added agent immediately findable with @ in the channel you added it to — and makes the agent you just created in the welcome flow mentionable right away.
These refreshes feed the next time the picker opens; an already-open suggestion list is deliberately kept stable (that contract is #7197).
Part of eight mention-editor PRs: shared recovery prerequisite #7190 → {#7191 → #7192, #7196 → #7323 → #7197 → #7239 → #7240}. This PR builds directly on #7191, whose membership refresh scheduler it uses.
Related issue
Continues the merged mention-editor work from #7124 (authorize remote mentions at publication) and #7128 (preserve spacing after multi-word mentions). No separate tracking issue for this slice.
Testing
membershipMentionJourney.test.mjscover the accepted channel-creation and Add-member refresh paths and the welcome-roster invalidation;membershipDirectorySync.test.mjsis extended here.mention-picker.spec.tsadds the journey — add the agent, then the first @ search finds it;onboarding.spec.tscovers the welcome-flow roster after starter provisioning, including choosing the exact newly created agent when its name collides. The fixture keeps both same-name agents and retains the fixed root's baseline ambiguous-submit regression: a typed colliding mention must fail visibly, keep the draft, and publish no event. The production fix for that visible failure is supplied by the shared fix(desktop): keep your draft editable when an @ mention cannot be sent #7190 prerequisite, not duplicated in this freshness delta.Historical capture state (not these heads)
The following original captions/links are retained as historical capture evidence only; none is relabeled as this restack.
Before: Add members cannot find the agent
At the parent revision,
21349006, the app already has an old agent list. Creating a channel does not refresh that list. Add members finds no matching agent. This image does not show a successful Add.After: Add succeeds and the first @ search finds the agent
At the earlier revision shown here,
c0da14c8, the same search finds Fresh Scout. Add succeeds. The first@Freshsearch shows Fresh Scout as a channel member. This PR does not include the later Member and Invite labels.