fix(db): attribute huddle_started_links pool acquisition (#7112 regression) - #7401
Open
rebekz wants to merge 1 commit into
Open
fix(db): attribute huddle_started_links pool acquisition (#7112 regression)#7401rebekz wants to merge 1 commit into
rebekz wants to merge 1 commit into
Conversation
Repair upstream regression c6ca9d9 by acquiring the event-store writer pool under the existing SubscriptionHistory operation label. Signed-off-by: Fitra Kacamarga <fitra.19@gmail.com>
🔐 Codex Security Review
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
huddle_started_links(crates/buzz-db/src/store/event.rs) calls.fetch_all(pool)directly, bypassing the typed pool-acquisition attribution that the rest of the event store uses. This trips the repo's own guard:Introduced in c6ca9d9 ("Show status and huddle indicators beside names", #7112).
Why CI did not catch it
The guard commit
91ab9d31bpredates #7112 by one day, so that PR's CI either did not run the guard or did not enforce its failure. Worth a look independently of this patch — the guard is currently not protectingmain.Fix
Acquire the connection through the existing
WriterOperation::SubscriptionHistorylabel, matching the convention already used by the neighbouringquery_events/count/get_last_message_atsubscription-history reads in the same file, where replica routing does not select a reader.SQL, binds, returned rows, ordering, and propagated errors are unchanged — this is attribution only.
Verification
cargo clippy --workspace --all-targets -- -D warningsclean.🤖 Generated with Claude Code