fix(desktop): require a Codex adapter with Astra support - #7427
Conversation
Signed-off-by: Stephen DeLorme <stephen@d.elor.me>
🔐 Codex Security Review
|
levmi
left a comment
levmi
left a comment
There was a problem hiding this comment.
Would love to see this land! I’m hitting the same issue on Buzz 0.5.22/macOS: Buzz’s codex-acp 1.3.0 bundles Codex 0.147.0, and Astra rejects requests even after updating my standalone CLI to 0.153.4. Having Buzz offer the managed adapter upgrade would be ideal—I’d prefer to stay on the normal update path.
Reviewed 5535c5c, including the shared version gate, readiness checks, install planning, post-install verification, and restart handling. No blocking findings. Discovery and installation use the same minimum, newer adapter versions remain accepted, and the updated regressions exercise the production checks.
Independently ran 48 relevant Rust tests and 31 settings UI logic tests; all passed.
One non-blocking release-validation suggestion: check the packaged Desktop flow from an older managed adapter through Update, confirm readiness recovers, and complete an Astra turn. I haven’t independently verified that end-to-end workflow.
Thanks for working on this! 🙂
|
running into the same issue myself, local testing:
Package references: 1.7.0 requires Codex |
wesbillman
left a comment
wesbillman
left a comment
There was a problem hiding this comment.
Carl, an automated reviewer, commenting via Wes’s GitHub account.
No blocking findings at head 5535c5cc21d47c0e04e492bff3012d3f0f6d5c1f, compared with base 3c7f288c60d67df78577b237e27c3dfc8831aaa1.
- Verified published npm metadata:
@agentclientprotocol/codex-acp@1.10.0is the currentlatestrelease and depends on@openai/codex ^0.153.3;1.6.2depends on^0.148.0. Executed the published 1.10.0 package’s--versionentry point and confirmed the exact output expected by Buzz’s parser. The package’s normal ACP launch resolves its bundled Codex unlessCODEX_PATHis explicitly supplied. - Traced the shared floor through discovery/readiness, Settings/onboarding update affordances, private-prefix install planning, fresh post-install verification, and subsequent runtime launch. The regression tests exercise the production classification/install-plan seams. Independent boundary review found no additional defects.
- Exact-head CI run succeeded.
git diff --checkpassed locally; broad suites were not rerun by me. The author’s live Astra prompt evidence was not independently repeated, and the packaged Desktop upgrade/restart workflow remains untested. Existing user-confirmed update and setup-mode-only automatic restart behavior are unchanged.
This is a review comment, not an approval submission.
…stody * origin/main: fix(desktop): require a Codex adapter with Astra support (block#7427) Signed-off-by: Joel Robotham <jrobotham@squareup.com>
Brings in 14 upstream commits: the npub identity standardisation for mobile and desktop (block#7488–block#7503, block#7493, block#7494), inline code in the app mono face via gpt_markdown 1.2.1 (block#6631), ACP fixes (block#7340, block#7325, block#7538), link-preview pacing (block#7211), mesh-llm 0.76.0-rc8 (block#6189) and the Codex Astra adapter gate (block#7427). Conflicts (4 files, 5 hunks) resolved as follows: - compose_bar/suggestions.dart: keep the fork's _RevealWhenSelected row and selection highlight, take upstream's `candidate.initial` for the avatar fallback so an unnamed candidate's compact npub does not render `N` for everyone. - message_content.dart: keep the fork's _buildMedia (ref + appContentAvailable) under gpt_markdown's four-argument imageBuilder; the `=WxH` size hint is ignored since media here is sized from imeta. Keep the fork's fenced code block (SelectionContainer.disabled, language label, Copy, horizontal scroll) and take upstream's CodeStyle colours so fenced and inline code share one face. `autolink: false` merged cleanly and is required: normalizeBareLinks() already links bare URLs. - invites/invite_create_provider.dart: keep both imports; upstream's shortPubkey replaces the local invite helpers. - test/.../channels_page_test.dart: keep the fork's navigatorObservers and take upstream's `profile` parameter. `tabReselection` is dropped — the fork removed it in eb1eefa when the tab bar became sidebar rows. Auto-merged files that the fork also edits were checked by hand: search_page and channel_tile took upstream's `user.initial` / dmAvatarInitial, forum and note cards lost their local _shortPubkey, and app.dart wraps the builder in AppMarkdownTheme. Verified locally: dart format, flutter analyze, flutter test (2,504), cargo fmt --check, just test-unit, file-size-check, BuzzPushKit compiles. Swift tests and device checks run on the Intel Mac. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G7tN8KwTRSSrHe2PSmnnM3 Signed-off-by: dhseo <birdblues@mac.com>
* origin/main: fix(markdown): align mention chip wrapping (#7501) fix(relay): reject presence updates when Redis storage fails (#7532) fix(desktop): let inbox title and message author names truncate under narrow panes (#7550) fix(buzz-acp): report missing models without retrying (#7538) fix(desktop): require a Codex adapter with Astra support (#7427) fix(desktop): order unnamed roster members by full canonical npub (#7503) fix(mobile): standardize public-key identity display on npub (#7493) fix(desktop): npub identity controls across profile, agents, and workflows (#7489) fix(desktop): npub identity displays for mention, member, and workflow surfaces (#7495) fix(desktop): shared npub identity foundation (canonicalNpub, PubKey gate, strict parser) (#7488) fix(mobile): render push notification sender identity as npub (#7494) fix(acp): pace targeted overflow recovery on consumer capacity (#7325) fix(link-preview): keep composer fetches user-paced (#7211) Signed-off-by: Meli <5aaa86bce934fc3445fc254aab560a40923f10252f92107e665073dede0e04d3@buzz.block.builderlab.xyz>
4 participants
Summary
Buzz considers codex-acp 1.6.2 current because the supported adapter floor is still 1.1.7. That adapter bundles Codex 0.148.0, so updating a separate Codex CLI to 0.153.4 leaves managed agents on the older runtime and unable to use GPT-6 Astra.
Raise the supported adapter floor to the published 1.10.0 release, which depends on
@openai/codex ^0.153.3. Existing discovery and installation code then classifies older adapters as outdated and offers the managed reinstall path. Update the availability and install-plan regressions to cover the observed 1.6.2 installation and the new minimum.This follows the existing version-floor policy. It does not automatically update a running installation: the user must complete Buzz’s offered adapter upgrade. Future upstream compatibility changes may require another floor update.
Related issue
No exact duplicate found in searches for Astra, CODEX_PATH, bundled Codex, outdated runtime, and codex-acp 1.10. Related: #3097 raised the older floor to 1.1.7 (already present on main); #2422 covers lost error details for runtime mismatches. Neither resolves this version gap.
Originating conversation: buzz://message?channel=3286cd76-f83e-4c7d-8317-10a16580744d&id=8b79a73078217222b870fff144c27e7d27bcd5a67c966869c18fe726db716898
Testing
OKandstopReason: end_turn; usage metadata confirms gpt-6-astra.git diff --checkpass.just desktop-tauri-test: 3,266 passed, 20 ignored, zero failures across the Desktop workspace and integration tests.just file-size-checkpass.just ci: still running the remaining mobile/build/workspace-test stages.The installed Buzz app and managed adapter were not replaced or restarted. The live check validates the new adapter/runtime path; a complete packaged Desktop upgrade workflow remains untested.