fix(mobile): keep iOS message menu actions responsive after rebuilds

[brow]

Long-pressing a message while the keyboard dismissed could leave the iOS action menu visible but unresponsive. Rebuilds installed a new selection handler before the previous hook's cleanup removed it. Keep that handler for the native view's lifetime and dispatch to the latest callback. Also let taps on decorative action icons reach the row control.

Added regression coverage for callback rebuilds, view replacement/dismissal, and native icon/label/edge hit targets. The callback regression fails before the fix and passes after it.

Validation: all 2,257 mobile tests (4 skipped), three unconfigured-push tests, mobile analysis, 42 focused action/handler tests, and three native XCTest checks passed. Physical iOS 26.5 taps verified keyboard-open long press, Edit, Copy (including clipboard contents), repeated opening, and outside dismissal. Desktop tests/builds, Tauri checks/tests, and the web build passed. The full local gate encountered unrelated Rust agent timeout failures; all 105 tests in the affected ACP test module passed when rerun serially.

GitHub CI passed, including mobile tests, Swift tests, Android build, and iOS simulator/release builds. Codex code review completed without findings.

No matching open issue or PR found.

Before

Synthetic message using the production long-press/menu components: Edit and Copy taps leave the menu open; tapping outside still dismisses it.

buzz-menu-before.mp4

After

With the keyboard open, the first Edit icon tap opens the editor. Reopening and tapping Copy copies the message and dismisses the menu.

buzz-menu-after.mp4

[github-actions]

🔐 Codex Security Review

Status: review required for the current range.

The current range is 5511b56fcf0047f9d0d4887dc75125b6933a6bbd...a49b21f6ddf3c6a0403a3bb692daeabccb6d4bad.
A new review must complete for this exact range. When manual authorization
is required, a Block organization member must comment exactly
@buzz-security-review a49b21f6ddf3c6a0403a3bb692daeabccb6d4bad to authorize a new review.
Any previous review applies only to its recorded range.

[brow]

@codex review

[brow]

@builderbot review

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-19T17:16:45.706168Z	a49b21f	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[brow]

@buzz-security-review a49b21f

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: a49b21f6dd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[jedwards27]

:bot: Jude’s code review agent

Verdict: APPROVE
Reviewed: 5511b56fcf0047f9d0d4887dc75125b6933a6bbd..a49b21f6ddf3c6a0403a3bb692daeabccb6d4bad (exact live head a49b21f6ddf3c6a0403a3bb692daeabccb6d4bad)
Risk: medium — user-visible iOS input handling across Flutter hook lifecycle and a native platform-view method channel.

Behavior/contracts traced: The per-view method channel is now owned by stable viewId, while a ref dispatches selections to the latest rebuild callback. View replacement and dismissal clear the appropriate handler; late old-view calls have no Dart handler; the existing one-shot selection guard prevents duplicate effects. Native action rows remain the sole accessible button, while decorative icon content no longer intercepts row taps.

Findings: No blocking or non-blocking code defect. The focused Dart regression is causally bound: restoring callback identity to the effect key fails the rebuild case by losing frame4:edit. Independent native mutation evidence likewise shows restoring icon interception fails the whole-row hit-target XCTest.

Author action: none.
Verification owner: CI/release gate for broader RunnerTests.xctest coverage and optional physical-device/VoiceOver dogfood; reviewer/tooling for any additional semantic traversal capture.

Validation at matching clean HEAD:

• just mobile-test — PASS: 2,257 tests, 4 skipped; unconfigured-push follow-up 3/3 PASS.
• just mobile-check — PASS: 577 files formatted, 0 changed; analyzer clean.
• cd mobile && flutter test test/features/channels/native_message_action_selection_test.dart — PASS 2/2.
• Causal mutation restoring [viewId, onSelected] — expected FAIL: rebuild test lost the second selection; candidate restored cleanly.
• Independent focused native XCTest and inverse hit-target mutation — PASS/expected FAIL on iPhone 17 Pro simulator, iOS 26.5.
• Exact-head GitHub Mobile, Mobile Swift, DCO, Semgrep, and zizmor gates — PASS.

Manual/native evidence: The attached before/after recordings show the failure and the repaired keyboard-open long-press → Edit → reopen → Copy → reopen → outside-dismiss journey. Independent simulator proof covered icon, label, and row-edge targets. Physical-device execution and clipboard contents were not independently repeated in this review.

Residual risk: Low. Repository CI builds the iOS simulator/release app but does not run the full RunnerTests.xctest suite; physical-device and VoiceOver traversal remain release/dogfood confidence gaps, not author-actionable defects.

[jedwards27]

Review verdict: APPROVE

Reviewed base 5511b56fcf0047f9d0d4887dc75125b6933a6bbd → exact live head a49b21f6ddf3c6a0403a3bb692daeabccb6d4bad.

No unresolved author-actionable defects found. Author action: none.

The fix puts selection-handler ownership on the native view identity rather than rebuild callback identity: useEffect(..., [viewId]) keeps one handler for that channel while useRef dispatches to the latest closure. Ordinary rebuilds therefore preserve the handler, view replacement moves it, and dismissal clears it. The native row also disables hit interception on its decorative icon container, preserving the row as the single accessible action while making icon, label, and edge taps reach the control.

Evidence at this exact head:

• Focused Dart lifecycle suite: 2/2 PASS. Restoring the old [viewId, onSelected] dependency causally failed the rebuild regression; restoring the candidate passed.
• Focused native whole-row hit-target XCTest: PASS on an iPhone 17 Pro / iOS 26.5 simulator. Re-enabling icon-container interaction causally failed the test; restoring the candidate passed.
• Focused Dart format/analyze: PASS.
• Attached before/after recordings cover the visible failure and the repaired Edit, Copy, reopen, and outside-dismiss journeys.
• Exact-head Mobile, Mobile Swift domain/results, DCO, Semgrep, and zizmor checks are green.

Non-blocking confidence gaps, owned by release/tooling rather than this author:

• CI does not currently execute RunnerTests.xctest; the changed focused XCTest was run independently, but not the entire RunnerTests suite.
• Physical-device clipboard-content behavior and VoiceOver traversal were not independently repeated. Static ownership/semantics, causal mutation tests, simulator behavior, and the supplied recording leave low residual risk; release/dogfood should retain those checks.

A new head invalidates this approval until its delta is reviewed.