feat(agents): humanize uncurated Databricks model ids with a label grammar

[wpfleger96]

New Databricks endpoints (Claude Opus 5.5, GPT-6 Astra/Sol, etc.) showed as raw FQNs in the model picker until someone added a curated corpus record for each. This adds a strict token-class grammar as a third label tier inside the Databricks label helpers (Rust model_capabilities.rs + TS modelCapabilities.ts): exact record → unique alias → generated label → raw id. In TS it fires only for an explicit databricks_v2 provider; providerless ids stay raw.

Grammar

Takes the last component of a UC FQN (or strips one wrapper: databricks-, goose-, kgoose-, builderbot-; an id that is neither stays raw), splits on -, and classifies each token as version, letter+digit version, size, trailing date (dropped), or word. Labels are built only from the id's own text, and the grammar never reinterprets a version. When in doubt it returns raw:

• Known families only. The family (leading letters of the first token) must be in the manifest's existing label_family_tokens. Custom endpoints such as prod.ai.rag-agent-3 or builderbot-pr-reviews-v2 stay raw. Supporting a new vendor means adding one entry to that list, not a record per model.
• Attached digits stay whole (gpt10 → GPT10). If the family already carries digits and the next token is a version (goose-qwen3-5-122b-a10b, system.ai.llama3-1-8b, system.ai.claude3-5-sonnet), the id stays raw; this is checked before any reorder.
• A third consecutive number (gemini-3-7-1-flash) returns raw rather than splitting off a patch version.
• Any non-ASCII input returns raw, checked before trimming or case folding.
• Any unclassifiable token, or no version-bearing token (builderbot-pr-reviews), returns raw. (latest)/Preview never appear unless an exact record supplies them.

Special cases, each justified by an unseen-id shape rather than the corpus score:

• meta-llama- → Llama: a namespace convention.
• Claude numeric-first reorder: Goose names Claude endpoints claude-4-7-opus. Only 1–2 version tokens followed by opus/sonnet/haiku reorder (claude-5-6-opus → Claude Opus 5.6); anything else keeps its order (claude-5-6-thinking → Claude 5.6 Thinking). Both current numeric-first ids also have exact records.
• Qwen compact decimal: Qwen's own naming qwen35 → Qwen3.5 when the second digit is nonzero.

Colliding labels in the picker

The same model is often served from several sources, so humanized labels collide (four rows are all GPT-5.5). disambiguateModelLabels in formatAgentModelLabel.ts suffixes only colliding Databricks labels with their source:

• UC FQN: its catalog.schema, e.g. GPT-6 Astra (system.ai) / GPT-6 Astra (sandbox.public).
• Workspace endpoint: its wrapper, e.g. GPT-5.5 (databricks) / GPT-5.5 (goose) / GPT-5.5 (kgoose).
• Still colliding after that (e.g. a date variant in the same schema): the full id, e.g. Gemini 3.7 Flash (system.ai.gemini-3-7-flash-0925).

Unique labels, raw-id rows, the default row, and other providers are unchanged. It runs in getDiscoveredPersonaModelOptions (covering AgentDropdownSelect, PersonaModelCombobox, PersonaDropdownField, whose closed triggers read the option label) and in ModelPicker. Model search in AgentDropdownSelect and PersonaModelCombobox also matches the raw id, so searching system.ai finds those rows. Rust ModelEntry.name is unchanged.

What labels drive

Picker values, persistence, routing, catalog dedup, resolve() and capabilities all stay keyed on the raw id; two ids sharing a label both remain selectable. Labels do drive picker search (alongside the raw id), the workspace catalog's equal-time sort, and TeamIdentityCard's "Mixed models" summary, which compares lowercased base labels, so goose- and system.ai GPT-6 Astra read as one model there (correct, since they are the same model).

Tests

Shared fixtures in scripts/databricks-label-fixtures.json are replayed by both Rust and TS. Each row asserts its tier: exact rows match a record, alias rows resolve with generation off, generated rows return nothing with generation off (so a future alias or record cannot mask them), and raw rows return nothing either way. A curator guard requires that across all 57 exact records, the ids the grammar does not reproduce equal exactly the 10 curator-only ids. disambiguateModelLabels has unit tests for namespace, wrapper, and full-id-fallback collisions, untouched rows, other providers, and case-insensitive grouping. The defaults-picker e2e checks the suffixed rows and trigger, raw-id search, and that choosing the second uncurated FQN by its visible name persists its raw id and restores its label. An edit-agent e2e covers the existing-agent model dropdown (#edit-agent-model): both suffixed rows render, the system.ai row is chosen by name, and after save and reopen the agent stores the system.ai id and shows GPT-6 Astra (system.ai).

[github-actions]

🔐 Codex Security Review

Note: This is an automated, security-focused review generated by Codex.
Use it as a supplement to human review; false positives are possible.

Scope

• Exact PR diff: 48884848f566d02c42ce07636636c4ad5f164c27...18f874ee2235aae6330672910d689fa3fd2b9aaa
• Model: gpt-5.6-sol

💡 Click "edited" above to see earlier reviews for this PR.

---

Review Summary

Overall Risk: NONE

No concrete security, correctness, or reliability findings. The changes affect Databricks display labels and collision disambiguation; model IDs remain unchanged for selection, persistence, capability resolution, and routing.

Findings

No concrete security, correctness, or reliability findings were identified.

Notes

• Review used read-only inspection only; repository scripts, builds, and tests were not executed as required.

---

_{Generated by Codex Security Review |
Requested by: @wpfleger96 |
Workflow run}

[wesbillman]

Carl, an automated reviewer, commenting via Wes’s GitHub account.

Changes requested

One P2 blocks this head: generated labels hide which namespace-distinct model target the user is selecting. Raw IDs correctly survive discovery, selection, persistence and routing, but that does not make identical picker rows distinguishable. The inline finding independently corroborates the existing collision report.

The separate attached-digit finding is P3/nonblocking: both interpreters agree, but can display ambiguous version grouping instead of taking the conservative raw fallback. It does not expand the blocking exit criteria.

Exit criterion: keep colliding choices and the selected target visibly/accessibly distinguishable, preserve raw-ID selection/persistence, and bind regressions to user-visible selection/search in Defaults and the existing-agent picker. Collision-only qualification or conservative fallback is sufficient; a model-family allowlist is not required by this finding.

Reviewed head 5f130546aabb6dd8479174e07049915fdf735543, exact base 3b2e50b15c6afba3ff3b8fbe1bdf0a7a69d29f7b, and the ten-file feature delta from their real merge-base 0ef7a2222ef4e9b221f310ac60ca6a535d9c840d. Source coverage includes both label interpreters, curated/provider precedence, catalog filtering/dedup/order, Defaults and existing-agent selection, raw-ID persistence/routing/capabilities, card/team consumers, and shared-fixture/E2E binding. The base-only hook commit is unrelated.

Validation is source-only on the pinned Blox host; no checkout, install, build, test or live reproduction. Existing exact-head CI snapshot: 53 successful, 27 skipped, one cancelled security-review check; no reruns or monitoring. This is not approval.

already addressed