Skip to content

fix(ci): run the admin disabled-mode DB test in the PostgreSQL lane - #7900

Merged
wpfleger96 merged 1 commit into
mainfrom
hayt/fix-admin-test-unit-exclusions
Sep 25, 2026
Merged

wpfleger96 merged 1 commit into
mainfrom
hayt/fix-admin-test-unit-exclusions

Conversation

@wpfleger96

@wpfleger96 wpfleger96 commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

api::admin::postgres_tests::disabled_mode_allows_unauthenticated_requests_on_the_admin_host falls through to a DB-backed read route but was not #[ignore]d. The test-unit exclusions meant to skip it still named api::admin::tests::…, which stopped matching when #6730 moved the admin tests into mod postgres_tests. As a result the test ran in the infra-free unit job and only passed after waiting out the sqlx acquire timeout (~150s in hosted CI), while the ignored-only PostgreSQL lane never ran it against a real database.

  • The test is now #[ignore = "requires PostgreSQL"], like its DB-backed peers, so the PostgreSQL lane runs it.
  • The two dead exclusions are removed, and the api::admin clause is just test(/^api::admin::/). nip98_mode_unrostered_signer_does_not_consume_a_replay_slot was already ignored and runs in the PostgreSQL lane.
  • The Justfile comment now states the convention (DB-backed admin tests are ignored; non-ignored ones reject before touching the DB), drops the stale reference to a ci.yml step that no longer exists, and keeps the timeout-trap warning.

@wpfleger96
wpfleger96 requested a review from a team as a code owner September 25, 2026 18:21
The test hits a DB fallthrough but was not #[ignore]d, so it only passed in
the unit job by waiting out the sqlx acquire timeout, and the exclusions
meant to skip it stopped matching after the move into mod postgres_tests.

Co-authored-by: Will Pfleger <pfleger.will@gmail.com>
Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
@github-actions github-actions Bot added the codex-security-review-current The posted Codex security review matches its recorded range. label Sep 25, 2026
@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

🔐 Codex Security Review

Note: This is an automated, security-focused review generated by Codex.
Use it as a supplement to human review; false positives are possible.

Scope

  • Exact PR diff: 9263cda8455b8fd27f4491e5e4fc0ebc2ce2e8bc...1ee750addf2c15a35201538433ec56941950555e
  • Model: gpt-5.6-sol

💡 Click "edited" above to see earlier reviews for this PR.


Review Summary

Overall Risk: NONE

No concrete security, correctness, or reliability issues found. The test is now excluded from database-free unit execution and is correctly discovered by the PostgreSQL CI profile through its postgres_tests module path and ignored-only configuration.

Findings

No concrete security, correctness, or reliability findings were identified.

Notes

  • No additional limitations were reported.

Generated by Codex Security Review |
Requested by: @wpfleger96 |
Workflow run

@wpfleger96
wpfleger96 force-pushed the hayt/fix-admin-test-unit-exclusions branch from 7a9e426 to 1ee750a Compare September 25, 2026 18:26
@github-actions github-actions Bot removed the codex-security-review-current The posted Codex security review matches its recorded range. label Sep 25, 2026
@github-actions github-actions Bot added the codex-security-review-current The posted Codex security review matches its recorded range. label Sep 25, 2026
@wpfleger96
wpfleger96 enabled auto-merge (squash) September 25, 2026 18:34
@wpfleger96
wpfleger96 merged commit b65cff3 into main Sep 25, 2026
81 checks passed
@wpfleger96
wpfleger96 deleted the hayt/fix-admin-test-unit-exclusions branch September 25, 2026 19:03
wpfleger96 pushed a commit that referenced this pull request Sep 25, 2026
…rcement

* origin/main:
  fix(ci): run the admin disabled-mode DB test in the PostgreSQL lane (#7900)
  🤖 docs: add pre-PR checklist and review guidance to AGENTS.md (#7897)

Signed-off-by: Duncan <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz>

# Conflicts:
#	Justfile
brow added a commit that referenced this pull request Sep 25, 2026
…ivery

* origin/main:
  feat(relay): enforce NIP-FI assertion+NIP-98 pairing on HTTP ingress (#7264)
  fix(ci): run the admin disabled-mode DB test in the PostgreSQL lane (#7900)
  🤖 docs: add pre-PR checklist and review guidance to AGENTS.md (#7897)
  docs: specify durable data backfills (#7326)
  docs(vision): add /buzz/v1 read endpoints to the protocol contract (#7879)
  🤖 fix(justfile): point just staging at the current staging relay (#7881)
  fix(relay-admin): make thread deletions atomic and fence expired action leases under row lock (#7853)
  feat(desktop): relay admin console for the /api/admin/v1 operator surface (#4768)
  fix(mobile): keep retired sections manager out of successor cache (#7873)

Signed-off-by: Tom Brow <tomb@block.xyz>

This branch was successfully deployed

1 active deployment
codex-review — 1ee750ad Deployed Sep 25, 2026 by wpfleger96 via Run Codex Security Review #5739
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex-security-review-current The posted Codex security review matches its recorded range.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants