fix(ci): run the admin disabled-mode DB test in the PostgreSQL lane - #7900
Merged
Merged
Conversation
The test hits a DB fallthrough but was not #[ignore]d, so it only passed in the unit job by waiting out the sqlx acquire timeout, and the exclusions meant to skip it stopped matching after the move into mod postgres_tests. Co-authored-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
🔐 Codex Security Review
Review SummaryOverall Risk: NONE
FindingsNo concrete security, correctness, or reliability findings were identified. Notes
Generated by Codex Security Review | |
wpfleger96
force-pushed
the
hayt/fix-admin-test-unit-exclusions
branch
from
September 25, 2026 18:26
7a9e426 to
1ee750a
Compare
wpfleger96
enabled auto-merge (squash)
September 25, 2026 18:34
TheSentinel454
approved these changes
Sep 25, 2026
wpfleger96
pushed a commit
that referenced
this pull request
Sep 25, 2026
…rcement * origin/main: fix(ci): run the admin disabled-mode DB test in the PostgreSQL lane (#7900) 🤖 docs: add pre-PR checklist and review guidance to AGENTS.md (#7897) Signed-off-by: Duncan <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz> # Conflicts: # Justfile
brow
added a commit
that referenced
this pull request
Sep 25, 2026
…ivery * origin/main: feat(relay): enforce NIP-FI assertion+NIP-98 pairing on HTTP ingress (#7264) fix(ci): run the admin disabled-mode DB test in the PostgreSQL lane (#7900) 🤖 docs: add pre-PR checklist and review guidance to AGENTS.md (#7897) docs: specify durable data backfills (#7326) docs(vision): add /buzz/v1 read endpoints to the protocol contract (#7879) 🤖 fix(justfile): point just staging at the current staging relay (#7881) fix(relay-admin): make thread deletions atomic and fence expired action leases under row lock (#7853) feat(desktop): relay admin console for the /api/admin/v1 operator surface (#4768) fix(mobile): keep retired sections manager out of successor cache (#7873) Signed-off-by: Tom Brow <tomb@block.xyz>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
api::admin::postgres_tests::disabled_mode_allows_unauthenticated_requests_on_the_admin_hostfalls through to a DB-backed read route but was not#[ignore]d. Thetest-unitexclusions meant to skip it still namedapi::admin::tests::…, which stopped matching when #6730 moved the admin tests intomod postgres_tests. As a result the test ran in the infra-free unit job and only passed after waiting out the sqlx acquire timeout (~150s in hosted CI), while the ignored-only PostgreSQL lane never ran it against a real database.#[ignore = "requires PostgreSQL"], like its DB-backed peers, so the PostgreSQL lane runs it.api::adminclause is justtest(/^api::admin::/).nip98_mode_unrostered_signer_does_not_consume_a_replay_slotwas already ignored and runs in the PostgreSQL lane.Justfilecomment now states the convention (DB-backed admin tests are ignored; non-ignored ones reject before touching the DB), drops the stale reference to a ci.yml step that no longer exists, and keeps the timeout-trap warning.