Skip to content

Split single boost/gil/concepts.hpp into boost/gil/concepts/*.hpp - #169

Merged
mloskot merged 1 commit into
boostorg:developfrom
mloskot:ml/split-concepts-hpp
Nov 17, 2018
Merged

mloskot merged 1 commit into
boostorg:developfrom
mloskot:ml/split-concepts-hpp

Conversation

@mloskot

@mloskot mloskot commented Nov 17, 2018

Copy link
Copy Markdown
Member

Replaces single, big, complex, of unclear logical structure, difficult to reason about concepts.hpp with collection of structured, clearly named headers.

This PR consists of pure refactoring changes:

  • move definitions to new files
  • replace Doxygen comments /** and **/with simple///` all the way
  • format some extremely long lines and template definitions to readable form respecting80-90 characters long lines
  • move some auxiliary internal definitions into namespace detail
  • add #include for missing headers
  • add #pragma GCC diagnostic ignored "-Wunused-local-typedefs"

This PR does NOT:

  • introduce functional changes
  • modify content of comments
  • modify tests

References

Tasklist

  • Review
  • Adjust for comments
  • All CI builds and checks have passed

@mloskot mloskot added cat/enhancement Improvements, but not fixes addressing identified bugs cat/refactoring Any nonfunctional changes labels Nov 17, 2018
@mloskot mloskot self-assigned this Nov 17, 2018
@stefanseefeld

Copy link
Copy Markdown
Member

Thanks for this work ! I find it quite hard to review, as the diff mostly just display added vs. deleted content, rather than providing insight into how things were re-arranged.
I assume this is (mostly) just about moving chunks of code into different locations, then using include directives to re-assemble them as needed ?
In other words, there aren't any semantically relevant changes to the code itself, right ?

@mloskot

mloskot commented Nov 17, 2018

Copy link
Copy Markdown
Member Author

@stefanseefeld Yes, it is difficult to review indeed.

I assume this is (mostly) just about moving chunks of code into different locations,
then using include directives to re-assemble them as needed ?

Correct.

In other words, there aren't any semantically relevant changes to the code itself, right ?

No, no functional changes introduced. Pure refactoring (as labelled :-))

I have just updated description of this PR listing what kind of changes it introduces.

@stefanseefeld

Copy link
Copy Markdown
Member

OK, thanks for confirming that. So I think all looks very good !

@mloskot mloskot added this to the Boost 1.70+ milestone Nov 17, 2018
@mloskot

mloskot commented Nov 17, 2018

Copy link
Copy Markdown
Member Author

Thanks

@mloskot
mloskot merged commit 7b5b01e into boostorg:develop Nov 17, 2018
@mloskot
mloskot deleted the ml/split-concepts-hpp branch November 17, 2018 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cat/enhancement Improvements, but not fixes addressing identified bugs cat/refactoring Any nonfunctional changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants