Use just ::value where is possible - #262
Merged
Merged
Conversation
Fixes VS2015 failures.
mloskot
self-requested a review
March 19, 2019 18:26
mloskot
approved these changes
Mar 19, 2019
mloskot
left a comment
mloskot
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks for making the clean up!
stefanseefeld
approved these changes
Mar 19, 2019
mloskot
added
cat/refactoring
1 task
Member
|
@Kojoley Thank you! @stefanseefeld Should this go to Boost 1.70? |
Member
|
Given that this is merely a cosmetic fix, I don't think this qualifies. |
Member
|
It fixes compilation for VS2015 users, doesn't it? I don't use VS2015 myself and I don't care about it, but there are users who do, apparently. |
Member
|
Oh, sorry, I had missed that. In this case it clearly does ! :-) |
Member
|
No problem. Good we've clarified that. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes VS2015 failures.
Usually all boolean (like
is_*,or,and) and integral (like*size*,*num*) metafunctions havevaluemember.References