Prefixed macros with BOOST

[Thihup]

Description

Prefixes some macros with BOOST

References

This pull request closes #410

[mloskot]

@Thihup Thank you for your contribution, awesome!

Please, refrain from promptly reacting to the further @ned14's suggestions for a moment.
I'm believe there are no changes needed in the auxiliary files, just C++ files, see #410 (comment)

[Thihup]

Hi @mloskot!

I'll wait to see if it's really necessary change the auxiliary files.

Sorry for the inconvenience.

[mloskot]

Sorry for the inconvenience.

No need, no problem. I just didn't want you to keep doing work unnecessarily.

[mloskot]

@Thihup I'd suggest to focus this PR on renaming C++ #define-ed macros only in all .hpp and .cpp files. Sounds good, do you agree?

Review of the auxiliary files is a good idea, but I'd prefer to do it in separate PR, as per my #410 (comment)

[Thihup]

Sounds good to me

[Thihup]

Should I prefix the macros in tests too?

[ned14]

For tests it's up to you, but for easy checking that you're good it's probably easiest.

[mloskot]

@Thihup

Should I prefix the macros in tests too?

Which macros you mean?

[Thihup]

GIL_Tests (test/legacy/performance.cpp | recreate_image.cpp)
GIL_TEST_CHANNEL_CONVERT_FROM (test/core/channel/algorithm_channel_convert.cpp) .

I think there is no others cpp to edit but those. If it's not necessary I think it's ready to merge.

[mloskot]

@Thihup

GIL_Tests (test/legacy/performance.cpp | recreate_image.cpp)

This is not an explicit #define-ed macro, but test suite name parameter.

This is part of Legacy Tests which are assumed promised as left untouched as per test/legacy/README.md.

However, I'd suggest to rename the two GIL_Tests to all lower-case gil_legacy_tests.

This should avoid confusing the macro check tooling.

GIL_TEST_CHANNEL_CONVERT_FROM (test/core/channel/algorithm_channel_convert.cpp) .

Yes, this can be prefixed indeed. Good catch.

[mloskot]

@Thihup Thank you very much for your help!