Skip to content

move number_precision::none code into a dedicated function - #1198

Draft
grisumbras wants to merge 1 commit into
boostorg:developfrom
grisumbras:refactor/no-precision-numbers
Draft

grisumbras wants to merge 1 commit into
boostorg:developfrom
grisumbras:refactor/no-precision-numbers

Conversation

@grisumbras

Copy link
Copy Markdown
Member

No description provided.

@cppalliance-bot

cppalliance-bot commented Sep 15, 2026 •

Copy link
Copy Markdown

An automated preview of the documentation is available at https://1198.json.prtest2.cppalliance.org/libs/json/doc/html/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2026-09-17 16:09:21 UTC

@cppalliance-bot

cppalliance-bot commented Sep 15, 2026 •

Copy link
Copy Markdown

GCOVR code coverage report https://1198.json.prtest2.cppalliance.org/gcovr/index.html
LCOV code coverage report https://1198.json.prtest2.cppalliance.org/genhtml/index.html
Coverage Diff Report https://1198.json.prtest2.cppalliance.org/diff-report/index.html

Build time: 2026-09-17 16:25:26 UTC

@cppalliance-bot

Copy link
Copy Markdown

@codecov

codecov Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.00791% with 86 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.98%. Comparing base (82398f9) to head (d0227d6).
⚠️ Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
include/boost/json/basic_parser_impl.hpp 66.00% 86 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1198      +/-   ##
===========================================
- Coverage    93.72%   92.98%   -0.74%     
===========================================
  Files           85       85              
  Lines         8981     9236     +255     
===========================================
+ Hits          8417     8588     +171     
- Misses         564      648      +84     
Files with missing lines Coverage Δ
include/boost/json/basic_parser.hpp 100.00% <ø> (ø)
include/boost/json/basic_parser_impl.hpp 93.25% <66.00%> (-5.43%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e93cf9c...d0227d6. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@grisumbras
grisumbras force-pushed the refactor/no-precision-numbers branch from d0227d6 to 1f8165e Compare September 17, 2026 15:59
@cppalliance-bot

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants