fix inner_active_ test in variant handler's on_array_end - #1203
Open
Ramya-9353 wants to merge 1 commit into
Open
Ramya-9353 wants to merge 1 commit into
Ramya-9353 wants to merge 1 commit into
Conversation
|
An automated preview of the documentation is available at https://1203.json.prtest2.cppalliance.org/libs/json/doc/html/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-10-01 07:20:00 UTC |
|
GCOVR code coverage report https://1203.json.prtest2.cppalliance.org/gcovr/index.html Build time: 2026-10-01 07:47:17 UTC |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Debug build,
parse_intointostd::variant<X, int>from{"z":[[0]]}:inner_active_in the variant handler is anintinitialised to -1, and every other test of it uses< 0, as do the tuple and described-class handlers that share that convention.on_array_endtests!inner_active_, which is true for alternative 0 and false when no alternative is selected, so while the first alternative is active the closing bracket of its own array is diverted tosignal_endinstead of being forwarded to it.Release build, same revision:
The third line is the one that bites.
ignoring_handlernever receives thearray_endthat would balance its depth counters, so they wrap, the described-class handler stays pinned on the ignore slot, andseen_stops being updated; X's three required members are all absent and the document is still accepted. Withinner_active_ < 0the three cases give[[1,2]],[[1],[2]]anderror::exhausted_variants.Tests added to
testVariantcover a nested-array alternative and the described-struct case. They fail on develop.