Repository navigation
[partial: stopped at the timeout] work/ostree-3690-review: Rework ostree#3690 per review - #38
Open
cgwalters-bot wants to merge 2 commits into
Conversation
This adds `work/ostree-3690-review/`, a reworked series for ostreedev/ostree#3690 that addresses the five review comments, with one short draft reply per comment in `REVIEW-REPLIES.md`. The series is now four commits. The boot_fd-only commit is folded into the /sysroot/boot one, and cleanup always does the rm_rf. `--hold` only also holds /boot when it is ostree's bind mount of /sysroot/boot, not an ESP. The `open_tree()` clone, its seccomp case and the remount-failure fallback are gone: /boot is remounted only when it is its own filesystem. On Fedora 44 BIOS VMs, main a4cb6781 still drops the staged deployment. With the fix, it finalizes with /boot on the root partition, with a separate /boot, and through soft-reboot. The bootc-integration suite passes 13/13, and its new test fails on main. `make check` gives the same results as main. `RESULTS.md` has the details and what wasn't covered. The bootc tmt test from devspace PR 35 has not been run against this series yet. ```checkpoint {"reason":"runtime","done":"Patches, review replies, RESULTS.md; PR 30 VM checks and make check","left":"PR 35 bootc tmt test, stock and fixed","next":"Use scripts/Containerfile.bootc-tmt and run cargo xtask run-tmt for localhost/bootc and the image with the series' RPMs layered on"} ``` Generated-by: AI
This was referenced Nov 6, 2026
Collaborator
Author
|
Continuation round 1 of 2 for Generated-by: https://github.com/cgwalters/#llms |
Collaborator
Author
|
Keep staged deployments intact when the /boot automount expires, incorporating the maintainer's review and stock/fixed bootc verification. Complete the checkpoint's evidence with the identical series tested in PR bootc-dev#41, without claiming a fresh VM run. Verified patch/tree identity and shell syntax. Generated-by: https://github.com/cgwalters/#llms
Collaborator
Author
cgwalters-bot
marked this pull request as ready for review
November 7, 2026 01:38
Collaborator
Author
|
Fix round 1 of 2 for Generated-by: https://github.com/cgwalters/#llms |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial work. The run was stopped at its timeout before the task was done; this is what it handed back.
This adds
work/ostree-3690-review/, a reworked series for ostreedev/ostree#3690 that addresses the five review comments, with one short draft reply per comment inREVIEW-REPLIES.md. The series is now four commits. The boot_fd-only commit is folded into the /sysroot/boot one, and cleanup always does the rm_rf.--holdonly also holds /boot when it is ostree's bind mount of /sysroot/boot, not an ESP. Theopen_tree()clone, its seccomp case and the remount-failure fallback are gone: /boot is remounted only when it is its own filesystem.On Fedora 44 BIOS VMs, main a4cb6781 still drops the staged deployment. With the fix, it finalizes with /boot on the root partition, with a separate /boot, and through soft-reboot. The bootc-integration suite passes 13/13, and its new test fails on main.
make checkgives the same results as main.RESULTS.mdhas the details and what wasn't covered.The bootc tmt test from devspace PR 35 has not been run against this series yet.
Closes #37