CI: Backport various fixes - #3141
Merged
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
3.23 has been tested in CI so is expected to work.
Removes some clang-tidy warnings and silences one about reinterpret_cast
Resolves: #3127
| * This can be a linearised and simplified form of FormFunction | ||
| */ | ||
| static PetscErrorCode FormFunctionForColoring(SNES UNUSED(snes), Vec x, Vec f, | ||
| static PetscErrorCode FormFunctionForColoring(void* UNUSED(snes), Vec x, Vec f, |
Contributor
There was a problem hiding this comment.
warning: function 'FormFunctionForColoring' declared 'static', move to anonymous namespace instead [misc-use-anonymous-namespace]
static PetscErrorCode FormFunctionForColoring(void* UNUSED(snes), Vec x, Vec f,
^| MatFDColoringSetFunction( | ||
| fdcoloring, reinterpret_cast<PetscErrorCode (*)()>(FormFunctionForColoring), | ||
| this); | ||
| MatFDColoringSetFunction(fdcoloring, |
Contributor
There was a problem hiding this comment.
warning: no header providing "MatFDColoringSetFunction" is directly included [misc-include-cleaner]
MatFDColoringSetFunction(fdcoloring,
^
Member
Author
|
Ok, now the tests are failing when trying to link using Presumably this was also fixed on |
Member
Author
|
Ok, we finally have |
dschwoerer
approved these changes
Jun 27, 2025
dschwoerer
left a comment
dschwoerer
left a comment
Contributor
There was a problem hiding this comment.
Thanks, its good to have a passing CI :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #3135 and #3138, just trying to get all the fixes in one PR so everything actually passes