Skip to content

Environment baseUrl #217

Open
Open

Description

@SharonGrossman

Hello, I would love to hear an opinion about how I can route the requests (for example search transactions) to another baseUrl and not the predefined ones that come with the chosen Environment.
I wanna do it for proxy reasons, and it seems we can't control that part of the configuration.
Thanks in advance!

P.S I can get up a PR to expose the url so it can be changed, but want to hear your thoughts before that

Activity

  1. Epreuve commented on Jan 24, 2023

    @Epreuve

    Hey @SharonGrossman, can you provide a use case for this? I'm not sure I follow the reasoning here.

    I misread the issue here. We're going to take a look at this a bit closer. I believe there has been some discussion about the Node SDK struggling to support Proxy configurations in a way that felt "right", but we're going to restart the discussion to see if there's any suggested paths forward for this.

  2. SharonGrossman commented on Jan 24, 2023

    @SharonGrossman
    Author

    Alright sounds awesome! I think the basic use case is providing another baseUrl to the configuration. I think implementing this isn't a big deal as the variables already exist (maybe I'm missing something)
    And again I would be more than glad to do it, if this indeed proves to be a good enough solution for the time being, while discussing a bigger scope
    Thanks for the quick response 🙏🏻

  3. hollabaq86 commented on Jan 26, 2023

    @hollabaq86

    👋 @SharonGrossman we're going to revisit proxy support all together for this library, as it's been some time since we originally encountered limitations (this was so long ago my memory is very fuzzy on the why 😄 ). In the interest of respecting your time, don't feel obligated to submit a PR.

    For internal tracking, ticket 2259

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions