Skip to content

Enable HTTP/2 for CURL #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mnapoli merged 3 commits into from
Sep 9, 2020
Merged

Enable HTTP/2 for CURL #740

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
04d29b2
Enable HTTP/2 for CURL
Sep 8, 2020
e1214ef
Update runtime/base/base.Dockerfile
Sep 9, 2020
b6aeec4
configure curl with ngtthp2 option
Sep 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 35 additions & 1 deletion runtime/base/base.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,39 @@ RUN set -xe; \
RUN set -xe; \
cmake --build . --target install

###############################################################################
# LIBNGHTTP2 Build
Comment thread
shouze marked this conversation as resolved.
# This adds support for HTTP 2 requests in curl.
# See https://github.com/brefphp/bref/issues/727 and https://github.com/brefphp/bref/pull/740
# # https://github.com/nghttp2/nghttp2/releases
# # Needs:
# # - zlib
# # - OpenSSL
# # Needed by:
# # - curl
ENV VERSION_NGHTTP2=1.41.0
ENV NGHTTP2_BUILD_DIR=${BUILD_DIR}/nghttp2

RUN set -xe; \
mkdir -p ${NGHTTP2_BUILD_DIR}; \
curl -Ls https://github.com/nghttp2/nghttp2/releases/download/v${VERSION_NGHTTP2}/nghttp2-${VERSION_NGHTTP2}.tar.gz \
| tar xzC ${NGHTTP2_BUILD_DIR} --strip-components=1

WORKDIR ${NGHTTP2_BUILD_DIR}/

RUN set -xe; \
&& CFLAGS="" \
CPPFLAGS="-I${INSTALL_DIR}/include -I/usr/include" \
LDFLAGS="-L${INSTALL_DIR}/lib64 -L${INSTALL_DIR}/lib" \
./configure \
--enable-lib-only \
--prefix=${INSTALL_DIR}


RUN set -xe; \
make install


###############################################################################
# CURL Build
# # https://github.com/curl/curl/releases/
Expand Down Expand Up @@ -244,7 +277,8 @@ RUN set -xe; \
--enable-cookies \
--with-gnu-ld \
--with-ssl \
--with-libssh2
--with-libssh2 \
--with-nghttp2


RUN set -xe; \
Expand Down