Repository navigation
Some minor improvments to the delete environment logic & other code clarity improvements - #524
Merged
Merged
Conversation
patelspratik
reviewed
Nov 5, 2026
|
|
||
| // IsCurrentUserSystemAdmin reports whether system-admin CLI behavior is enabled | ||
| // for the current credential. API keys and feature.not_admin disable it. | ||
| func IsCurrentUserSystemAdmin(store CurrentUserAuthStore) (bool, error) { |
Contributor
There was a problem hiding this comment.
is this even a real use case? I was struggling to refactor this a bit, but I'm not sure this use case really exists or should exist and using the Admin UI makes more sense to me than having the CLI do it. Thoughts?
patelspratik
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found
featureflag.IsAdminto be confusing, so I renamed it tofeatureflag.UseSystemAdminFeatures. I also foundhandleAdminUserconfusing in the delete method, so I refactored that a big.I also made use of the existing
FindUserWorkspaceByNameOrIDso we could get rid of an instance of error string matching.