Repository navigation
fix: prevent secret values in CLI command telemetry (BRE2-1283) - #525
Merged
Merged
Conversation
jarrad
marked this pull request as ready for review
November 5, 2026 12:35
drewmalin
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
brev secrets create --valueandbrev secrets set-value --valueflags sensitive.BRE2-1283 is canonical. BRE2-1287 is an exact duplicate with a separate scanner fingerprint.
Validation
go test ./pkg/analytics ./pkg/cmd/secrets ./pkg/cmdgit diff --check origin/main...HEADmainat13886423a2ef445cf36b3e690c0e701ae17445f8.Historical exposure follow-up
Assess affected released CLI versions, whether the PostHog feature gate was enabled, and the event time window and population using metadata and counts only. Do not query or export secret values. If exposure is confirmed, coordinate event deletion and targeted credential rotation through the incident process. This assessment is tracked on BRE2-1283 and was not performed in this PR.