Support idle_in_transaction_session_timeout and statement_timeout for native driver#2323
Support idle_in_transaction_session_timeout and statement_timeout for native driver#2323shayonj wants to merge 3 commits into
Conversation
shayonj
force-pushed
the
s/lib-native-options
branch
2 times, most recently
from
4cc6167 to
1bda055
Compare
shayonj
changed the title
|
An expedient (and better review than what I could offer myself) would be super appreciated here. 🙏 Supporting good timeouts is critical for us to run the native driver in production at Loom. ❤️ |
|
Yo - sorry I was late to the party here. Left a question on here....could we include a test when both |
… native driver Right now when using `pg` with `pg-native` the config options `idle_in_transaction_session_timeout` and `statement_timeout` do not get applied. This is due to, when building the connection string for native driver these options aren't passed in. I took advantage of `options` conn parameter and passed both the config options into it using `-c` which postgres supports. This builds on top of the work happened in <TBD LINK>. Also added some tests. Very much open to feedback and comments :).
shayonj
force-pushed
the
s/lib-native-options
branch
from
1bda055 to
b16711f
Compare
shayonj
force-pushed
the
s/lib-native-options
branch
from
b16711f to
e3f89ce
Compare
|
late to the part myself this time, thanks @brianc for the review, updated with some more spec 🙌 |
|
Hi, @brianc! Is this PR still under consideration? Having this fully supported would be great. We are moving more of our libraries at work toward using Thanks for all your fantastic work on these libraries! |
4 participants
Right now when using
pgwithpg-nativethe config optionsidle_in_transaction_session_timeoutandstatement_timeoutdo not get applied. This is due to, when building the connection
string for native driver these options aren't passed in.
I took advantage of
optionsconn parameter and passed both the config optionsinto it using
-cwhich postgres supports. This builds on top of the work happened in #2216.Also fixes #2103
Also added some tests. Very much open to feedback and comments :).