Repository navigation
refactor(move): move artifact guards to test/repo-guards - #3663
Merged
Merged
Conversation
Specifier and root-path fixes follow in the next commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…epo-guards Root-relative path fixes, comment references, and the unit-core include entries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Reviewed 5b52407. The move of the artifact guards to test/repo-guards looks correct, and I found no problems in the diff. The change only moves tests and edits one test config. I ran no tests locally, so the result rests on reading the diff. I grepped package.json, scripts and .github for the old src/tests paths. I did not check whether other lanes, such as mutation or coverage, point at them. The path root in exec-wrap-guard I inferred from the two-line diff, not from the full file. CI is still pending: 17 jobs are queued and none have failed. Nothing else blocks this once the queue goes green. I know of no conflicts. |
Contributor
Size Report
Startup median (7 runs, lower is better):
|
This was referenced Oct 15, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Class i, repo-level artifact guards: six tests assert on Swift sources,
package.json, workflows, docs or thesrctree rather than on one module, so they leavesrc/__tests__fortest/repo-guards/. Their names already say what they guard, so none is renamed.vitest-slow-test-reportertests a script module and moves beside its sibling script tests inscripts/__tests__/.apple-runner-log-redactionapple-runner-package-sourcescripts/package-apple-runner-source.mjsexec-wrap-guardsrcnpm-package-scriptspackage.jsonscripts + workflowspackage-exportspackage.jsonexports +tsdown.config.tsclient-api-examples-driftexamples/sdkvs the API docsCommit 1 is a pure
git mv(7 renames, 0 content lines). Commit 2 fixes the one root-relative path (exec-wrap-guardscanssrc), the slow-reporter import, two comments naming the old path, and adds theunit-coreinclude entries:test/repo-guards/*.test.tsand the slow-reporter file (the scripts list is explicit). No new vitest project, noexports, barrel or fixture change.Validation
Head
5b52407ab:check:quick,check:layering,check:fallow,check:gate-manifest,check:affected --run,pnpm formatpass.vitest listshows every new path under[unit-core]; the full affected run covers them.AppErrorwith the stdout/stderr/exitCode trio undersrcmakesexec-wrap-guardfail naming it; removed afterwards.apple-runner-log-redaction.test.tsstay valid (bare filename) and are untouched to avoid selecting Apple lanes.🤖 Generated with Claude Code