Skip to content

test(capture-kit): encode solid test PNGs unfiltered to stay inside the unit budget #3933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thymikee merged 1 commit into from
Oct 23, 2026
Merged

test(capture-kit): encode solid test PNGs unfiltered to stay inside the unit budget #3933

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions packages/capture-kit/src/screenshot-diff.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,13 @@ function tmpDir(): string {
return mkdtempForTestSync('agent-device-screenshot-diff-');
}

/** Create a solid-color PNG and write it to disk. */
/**
* Create a solid-color PNG and write it to disk. `filterType: 0` skips the
* per-scanline deflate filters: for a solid image they only make the encoder
* slower (the full-resolution cases spent ~0.8s encoding under coverage).
* Filtering is a lossless transform the decoder inverts, so the decoded
* pixels — everything these tests compare — are unchanged.
*/
function writeSolidPng(
filePath: string,
width: number,
Expand All @@ -26,7 +32,7 @@ function writeSolidPng(
png.data[i + 2] = color.b;
png.data[i + 3] = 255;
}
fs.writeFileSync(filePath, PNG.sync.write(png));
fs.writeFileSync(filePath, PNG.sync.write(png, { filterType: 0 }));
}

/** Encode a solid-color JPEG, so a test can hand the comparison a lossy container. */
Expand Down
Loading