Repository navigation
Conversation
The Oct 25 weekly sweep timed out kernel-errors-4: the resource-ownership error reasons grew errors.ts past 350 mutants, and the shard holding the slow-test region crawled past the 22-minute step budget before Stryker wrote a report. The score job then failed on the incomplete shard set (17/18), which is the designed indictment of a dead shard, not a separate fault. Eight slices put every bin inside the budget; the affected lane derives its matrix from the same registry, so it follows without edits.
Contributor
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="scripts/mutation/modules.ts">
<violation number="1" location="scripts/mutation/modules.ts:48">
P3: This comment names the wrong budget: a bin is killed by the 22-minute mutation step, not the 30-minute job. Also, the ~400-mutant figure differs from the PR description's "past 350". Reword the comment to cite the 22-minute step and drop the unverified mutant count, which will go stale as errors.ts grows.</violation>
</file>
Reply to a comment to ask cubic a question or push back. It learns from your replies.
View guided diff | Re-trigger cubic
Comment on lines
+48
to
+50
| // errors.ts keeps growing (resource-ownership reasons landed ~400 mutants, | ||
| // and the slow-test region alone outran a 22-minute shard); eight slices | ||
| // hold every bin inside the lane's 30-minute job budget. |
Contributor
There was a problem hiding this comment.
P3: This comment names the wrong budget: a bin is killed by the 22-minute mutation step, not the 30-minute job. Also, the ~400-mutant figure differs from the PR description's "past 350". Reword the comment to cite the 22-minute step and drop the unverified mutant count, which will go stale as errors.ts grows.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At scripts/mutation/modules.ts, line 48:
<comment>This comment names the wrong budget: a bin is killed by the 22-minute mutation step, not the 30-minute job. Also, the ~400-mutant figure differs from the PR description's "past 350". Reword the comment to cite the 22-minute step and drop the unverified mutant count, which will go stale as errors.ts grows.</comment>
<file context>
@@ -45,7 +45,10 @@ export const KERNEL_MODULES: readonly KernelModule[] = [
mutate: ['packages/kernel/src/errors.ts'],
owns: ['packages/kernel/src/errors.ts'],
- shards: 5,
+ // errors.ts keeps growing (resource-ownership reasons landed ~400 mutants,
+ // and the slow-test region alone outran a 22-minute shard); eight slices
+ // hold every bin inside the lane's 30-minute job budget.
</file context>
Suggested change
| // errors.ts keeps growing (resource-ownership reasons landed ~400 mutants, | |
| // and the slow-test region alone outran a 22-minute shard); eight slices | |
| // hold every bin inside the lane's 30-minute job budget. | |
| // Eight slices keep each bin inside the 22-minute mutation step timeout; the | |
| // 30-minute job also covers setup and upload, so it is not the binding limit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What happened
The Oct 25 weekly sweep failed two jobs in one chain:
Mutants (kernel-errors-4)was killed by the step's 22-minute timeout with Stryker at 41% (20→41% over the last minutes,remaining: ~5mand climbing), andMutation score reportthen failed on the incomplete shard set (17/18) — the report lane's designed indictment of a dead shard, not a separate fault.packages/kernel/src/errors.tskeeps growing (the resource-ownership error reasons #3887 landed alone pushed the module past 350 mutants, and its slow-test region runs ~28 s/mutant), so the shard holding that region can no longer finish inside the budget. The lane's own registry comment names the remedy: "a module big enough to outrun the lane's 30-minute budget declares more".Fix
kernel-errorsshards: 5 → 8. The slow region is diluted to ~10–12 minutes per bin, inside the budget with headroom. Everything the registry drives follows mechanically:shardMatrix()and the weekly matrix gainkernel-errors-6/7/8;--expect-shards18 → 21.mutation-affectedderives its matrix from the same registry and needs no edits; its step budget stays at the tested 22 minutes.Verified:
node --test scripts/mutation/*.test.ts— 70/70 pass.