security: harden loopback OAuth callback and require token for API listeners - #2292
Merged
callumalpass merged 1 commit intoSep 13, 2026
Conversation
martin-forge
force-pushed
the
martin-forge/harden-oauth-callback-and-listener
branch
from
September 11, 2026 10:53
ab9bbd2 to
4ae127f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An empty API token currently permits unauthenticated requests. The OAuth callback also searches for a free port before binding it and inserts callback error text into its HTML response.
This change generates and saves a strong token before starting the API/MCP listener, and rejects requests when no token is configured. It lets the OS allocate the OAuth port, registers the callback before opening the browser, accepts each pending callback once, and returns fixed HTML with restrictive headers. It follows the loopback protection in #1923.
Validation:
npm run build:testpass.Rebased onto current main with the release-note conflict resolved. The implementation and regression tests are unchanged by the rebase.