fix(google-calendar): resolve the primary calendar alias in every lookup - #2309
Merged
callumalpass merged 1 commit intoSep 13, 2026
Conversation
martin-forge
force-pushed
the
martin-forge/fix-google-primary-calendar-lookups
branch
from
September 9, 2026 20:00
fe23007 to
7ee6d40
Compare
martin-forge
changed the title
A Google calendar enabled as `primary` is fetched under that alias, so its events carry `primary` as their calendar id while the calendar list reports the account's real id. Event cards already reconcile the two; three other lookups compared ids directly and missed. The calendar's own color was replaced by the default Google blue, its per-calendar visibility toggle matched nothing and so never hid anything, and mini calendar entries and event-linked notes fell back to the generic provider name. Resolve the alias through one shared helper, and register the account's own calendar under both keys when building visibility toggles. Event and subscription ids are unchanged, so notes already linked to alias-fetched events still match.
martin-forge
force-pushed
the
martin-forge/fix-google-primary-calendar-lookups
branch
from
September 11, 2026 10:50
7ee6d40 to
f4e3f17
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a Google calendar is enabled using the
primaryalias, fetched events carry that alias while the calendar list uses the account’s actual ID. Direct ID lookups then lose the calendar’s colour and name, and its visibility toggle fails to hide its events.This change shares the alias lookup across calendar views, event cards and linked notes, and registers visibility toggles under both IDs. Event and subscription IDs stay unchanged so existing linked notes continue to resolve.
Validation:
npm run build:testpass.Rebased onto current main; the release-note conflict is resolved and unrelated formatting changes have been removed.