Memory System Fixes - #16
Merged
Merged
Conversation
…us from qdrant and also adding env variables and updating search filter supports basic syntax including in, and, or, gte, le, ge, lte
…us from qdrant and also adding env variables and updating search filter supports basic syntax including in, and, or, gte, le, ge, lte
…us from qdrant and also adding env variables and updating search filter supports basic syntax including in, and, or, gte, le, ge, lte
Ptah-CT
pushed a commit
to DerAuctor/ct-cipher
that referenced
this pull request
Oct 2, 2025
…or-store-service Memory System Fixes
hieuntg81
added a commit
that referenced
this pull request
Apr 22, 2026
…iew #16) resolveHome only expands a leading ~. Relative paths like `./id_ed25519` or bare `id_ed25519` passed straight through and then resolved against the daemon's CWD — so the same config value worked today and broke tomorrow if the daemon restarted from a different directory. Reject non-absolute paths at both entry points (handleConfig set and handleImportGitSigning) with INVALID_CONFIG_VALUE. Matches the semantic of `git config user.signingKey`, which also requires an absolute path. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Fix: Resolve Test Failures for Memory System Refactor
Overview
This PR addresses and resolves all test failures from PR #15.
Key Fixes
InternalToolManagerfor reliable tool execution in tests.Note: A dedicated test file,
@pr-validation.test.ts, is included for validation, and all test cases now pass.Display Order Note
The logic for switching the display order of the agent response and
cipher_extract_and_operate_memorylogs (as described in the previous PR and shown in your image) remains unchanged.The relevant code in
src/core/session/conversation-session.ts(lines ~60-65) is still accurate, and the display order can still be easily switched as before.Related PRs