Skip to content

calculate signature properly + fix package.json too be valid json - needed for npm - #3

Open
forty wants to merge 2 commits into
campfirelabs:masterfrom
forty:master
Open

forty wants to merge 2 commits into
campfirelabs:masterfrom
forty:master

Conversation

@forty

@forty forty commented Feb 8, 2013

Copy link
Copy Markdown

Those commits fix:

1/ The signature is currently calculated improperly

This causes error such as error: 'Invalid API signature'

2/ Currently npm fails to install the module because package.json is invalid:

npm ERR! Failed to parse json
npm ERR! Unexpected token }
npm ERR! File: ../mixpanel-api/package.json
npm ERR! Failed to parse package.json data.
npm ERR! package.json must be actual JSON, not just JavaScript.
npm ERR!
npm ERR! This is not a bug in npm.
npm ERR! Tell the package author to fix their package.json file. JSON.parse

@FRickReich

Copy link
Copy Markdown

still failing.

@forty

forty commented Feb 21, 2013

Copy link
Copy Markdown
Author

What is failing? Did you pull my repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants