Repository navigation
fix: thank only contributors credited by handle - #18
Merged
tonyandrewmeyer merged 1 commit intoOct 15, 2026
Merged
Conversation
The credit regex read any entry ending in "by <words> ([#N](...))" as a name credit, so canonical/charmlint's draft 0.3.0 release thanked "default" for "Deselect the reference-URL checks by default (#391)". A name credit can't be told apart from a summary like that, so the thanks line now only picks up @Handles, which are also the only credits that notify anyone. Name credits stay on their changelog entries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
@james-garner-canonical I think this is why you got the thanks to "name", because of this line. |
tonyandrewmeyer
marked this pull request as ready for review
October 9, 2026 10:30
james-garner-canonical
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The thanks line at the end of a release body now only thanks contributors credited by
@handle. Before, the credit regex read any entry ending in "by " followed by its PR link as a credit by name, so the draft 0.3.0 release of charmlint ended with "Thanks default for your contribution to this release!", from "Deselect the reference-URL checks by default (#391)". The same would happen in operator with a PR title such as "Handle errors raised by Pebble".A credit by name (
* Warm the pot by Hazel Grouse (#103)) reads exactly the same as a summary that ends in "by" something, so there isn't a regex that gets both right. I've dropped names from the thanks line rather than change how name credits are written in every repo'sCHANGES.md. Someone credited by name keeps the credit on their entry, and only a handle notifies anyone, which is what the thanks line is for.