Skip to content

T3 Code clone: show traits and step reasoning effort - #744

Merged
daehyeon-mun merged 5 commits into
daehyeon/t3-code-mainfrom
daehyeon/t3-up-composer-traits-models
Oct 18, 2026
Merged

daehyeon-mun merged 5 commits into
daehyeon/t3-code-mainfrom
daehyeon/t3-up-composer-traits-models

Conversation

@daehyeon-mun

@daehyeon-mun daehyeon-mun commented Oct 18, 2026 •

Copy link
Copy Markdown
Collaborator

Request

Composer and settings traits now show Fast or Ultrafast beside the reasoning label. Source control writer and review-guide models have trait pickers that preserve the other selected options, including project overrides. Subagent hover cards show the matching model’s effort and speed.

Changes and reasons

Adds unbound Increase Effort and Decrease Effort commands with wrapping levels and caret-preserving Ultrathink prompt edits. Exact model-name matches rank first, equal search matches keep catalog order, missing text-generation models prefer the provider’s cheap default, and ⌘Enter creates a project while an option is highlighted.

Follows T3 Code 9c161462c9, specifically e22c880434 (#16069), 29366ea29a (#13056), e688034b5f (#18488), 2993dfc069 (#19928), ede3f2d6ba (#18494), 45b5993a52 (#19722), and 446be6933f (#18901).

Verification

Verified source commit: 381870af4dd33d2ead0c4e22e1da063d7f8cf08c. The native image and build below qualify the original implementation at 1fdc7f37966b6975d5b57d0e9a8d8aaecb950c55; the later default/scope correction is covered by focused tests and the real-server check.

Acceptance Result Proof
Traits speed labels and source control model traits Pass in behavior tests Traits/settings cases
Effort steps wrap, preserve other traits, and retain the caret Pass in behavior tests Effort cases
A refused native prompt edit preserves newer typing Pass Editor boundary case
Subagent hover cards receive matching effort and speed only Pass Timeline case
Exact-name ranking, position-independent ties, cheap text defaults Pass Model cases
Highlighted-option ⌘Enter dispatch and hint Pass Contract action and palette cases
Saving new effort bindings and review-guide settings to the new server Pass with restart readback Exact app restCommand planners issued 10 settings writes and two keybinding writes against isolated runtime 0.1.1-nightly.20261018.3302. Both models retained effort/speed traits at environment and project scope; both effort bindings survived restart.
Review guides default and scope Pass Defaults off; the toggle is disabled for project scope. A project toggle write is rejected before any RPC mutation. The review-guide model remains project-scoped.

The default/scope correction passes 244 focused composer/settings tests (2,395 assertions), strict TypeScript, caps and whitespace checks. Upstream packages/contracts/src/settings.ts confirms the false default and excludes reviewGuidesEnabled from project-scoped keys.

Original implementation verification completed: generated sources; all 5,274 Bun tests pass across 367 files; strict TypeScript passes; the full Contract compiles to 105,001 nodes; caps pass; git diff --check passes. Terminal assets build. Offline runtime staging verifies the pinned archive, all 11 Mach-O signatures, the version, and a live server start/stop on isolated port 16862.

The signed native macOS bundle builds successfully (Cargo 481.1 s, shared Swift 14.0 s, app Swift 156.2 s). All 25 Cargo data tests pass in the host-dev profile. A live native drive opened Source Control settings, scrolled to the model settings, and captured the current window at 1280×840. The same isolated offline fixture and viewport were used for the baseline. The offline fixture has no text-generation providers; model option behavior is covered by the focused tests above.

Source Control settings before and after

The comparison is attached to this PR through GitHub; no evidence is committed.

The integration merge preserves the runtime’s 16 standard client scopes and settings-write permission, the timeline’s linked-thread labels, and composer model options including boolean speed traits. Post-merge verification: 1,221 affected tests pass across 80 files, strict TypeScript/caps/whitespace pass, and the full Contract compiles to 103,465 nodes (5,941 slots; 24 derives; 75 resources; 9,969 actions). Grouped keybindings, mobile store links, timeline handoff dividers and subagent hover traits are retained. Both the dedicated and aggregate project planners now reject review-guide enablement overrides. The exact app planner/new-server restart readback passed on e66ce91153; the final timeline-only reconciliation is 381870af4d. No additional native build was run; the coordinator’s final integrated native proof will cover the combined source.

Risks and dependencies

#740 merged as cf8ca5244e15f72b59bee08788f3be9014509622. Its immutable archive was independently verified (SHA-256 6bd4ba617d321f31ac0c4bffe154ab14bf9ed8d67a7c244dcbda4c5f9581c521, 11 Mach-O signatures) and exercised through this PR’s exact app planners with actual RPC readback before and after a server restart. The fixture uses empty provider homes and no machine credentials. The guided-review task owns the guide tour itself; this PR supplies its model controls. No framework blocker was found.

The shared settings menu and its option/palette declarations moved into two small Contract files so both settings pages can use the same controls without an import cycle. No Exact framework changes.

Next action

Review the default/scope correction and the persistence readback, then integrate this draft into daehyeon/t3-code-main.

Prepared with Codex; continues work begun in the prior Claude session.

Co-Authored-By: Codex <noreply@openai.com>
@daehyeon-mun

Copy link
Copy Markdown
Collaborator Author

Source Control settings before/after at 1280×840, same isolated offline local fixture. The after view includes the review-guide controls; behavior tests cover model traits and editor commands.

Source Control settings before and after

@daehyeon-mun

Copy link
Copy Markdown
Collaborator Author

Real-server persistence check passed for 565187dbb5aade0cde17145b888e34d9938e7040 against runtime 0.1.1-nightly.20261018.3302. The exact app restCommand entry point made 10 settings writes and two keybinding writes. All selections and bindings were read back after restarting the isolated server. An unsupported project-level review-guide toggle was rejected before any update RPC. Synthetic fixture only; no machine credentials.

{
  "implementation": "565187dbb5aade0cde17145b888e34d9938e7040",
  "runtime": "0.1.1-nightly.20261018.3302",
  "actualAppEntryPoint": "restCommand \u2192 scopedPatch / keybindingPayload",
  "readback": {
    "serverVersion": "0.1.1-nightly.20261018.3302",
    "reviewGuidesEnabled": true,
    "reviewGuideModelSelection": {
      "instanceId": "codex",
      "model": "gpt-5.4",
      "options": [
        {
          "id": "reasoningEffort",
          "value": "high"
        },
        {
          "id": "fastMode",
          "value": true
        }
      ]
    },
    "sourceControlWriterModelSelection": {
      "instanceId": "codex",
      "model": "gpt-5.4",
      "options": [
        {
          "id": "reasoningEffort",
          "value": "medium"
        },
        {
          "id": "fastMode",
          "value": false
        }
      ]
    },
    "projectOverride": {
      "sourceControlWriterModelSelection": {
        "instanceId": "codex",
        "model": "gpt-5.4",
        "options": [
          {
            "id": "fastMode",
            "value": true
          },
          {
            "id": "reasoningEffort",
            "value": "low"
          }
        ]
      },
      "reviewGuideModelSelection": {
        "instanceId": "codex",
        "model": "gpt-5.4",
        "options": [
          {
            "id": "reasoningEffort",
            "value": "high"
          },
          {
            "id": "fastMode",
            "value": false
          }
        ]
      },
      "branchNamePrefix": "fixture-"
    },
    "effortBindings": [
      {
        "command": "composer.increaseEffort",
        "shortcut": {
          "key": "arrowup",
          "metaKey": false,
          "ctrlKey": false,
          "shiftKey": false,
          "altKey": true,
          "modKey": true
        },
        "whenAst": {
          "type": "identifier",
          "name": "composerFocus"
        }
      },
      {
        "command": "composer.decreaseEffort",
        "shortcut": {
          "key": "arrowdown",
          "metaKey": false,
          "ctrlKey": false,
          "shiftKey": false,
          "altKey": true,
          "modKey": true
        },
        "whenAst": {
          "type": "identifier",
          "name": "composerFocus"
        }
      }
    ]
  },
  "serverRestarted": true,
  "unsupportedProjectToggleRejectedBeforeWrite": true,
  "settingsWrites": 10,
  "keybindingWrites": 2
}

The existing native build/image qualifies 1fdc7f37966b6975d5b57d0e9a8d8aaecb950c55; the subsequent default/scope correction passes 244 focused tests, strict TypeScript, caps and whitespace checks.

daehyeon-mun and others added 2 commits October 19, 2026 00:15
Preserve runtime settings and scopes, linked timeline rows, and model trait fields.

Co-Authored-By: Codex <noreply@openai.com>
Preserve grouped keybindings, mobile store links and environment-only review-guide enablement.

Co-Authored-By: Codex <noreply@openai.com>
@daehyeon-mun

Copy link
Copy Markdown
Collaborator Author

Post-integration verification passed on e66ce91153f249f7c07968b1df76c1e083097861: 1,227 affected tests, strict TypeScript, caps and whitespace checks; full Contract preflight (99,340 nodes). The exact app restCommand planner check against runtime 0.1.1-nightly.20261018.3302 passed again, including 10 settings writes, two effort-keybinding writes and readback after restarting the isolated real server. Grouped keybindings/store links are retained, and both project planners reject environment-only review-guide enablement. Native evidence remains qualified to its original source head; the coordinator owns final combined native verification.

Co-Authored-By: Codex <noreply@openai.com>
@daehyeon-mun
daehyeon-mun marked this pull request as ready for review October 18, 2026 15:29
@daehyeon-mun
daehyeon-mun merged commit e6f6810 into daehyeon/t3-code-main Oct 18, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant